build linux artifacts in containers. re-use cmake workflow. #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scareything
commented
Oct 18, 2022
| container: ubuntu:18.04 | ||
| name: Linux arm | ||
| install: crossbuild-essential-armhf libsystemd-dev | ||
| install: $common_ubuntu_deps crossbuild-essential-armhf | ||
| toolchain: Linux-arm.cmake | ||
| cmake_opts: -DCMAKE_BUILD_TYPE=Release |
There was a problem hiding this comment.
I noticed that we had not been building our release binaries with openssl. Should we? @ekoby?
ekoby
reviewed
Oct 18, 2022
| git config --global --add safe.directory $GITHUB_WORKSPACE | ||
| git --version | ||
|
|
||
| - name: install contemporary cmake |
There was a problem hiding this comment.
there is an action for it: lukka/get-cmake
you get benefit of caching
ekoby
approved these changes
Oct 18, 2022
|
Loving the callable workflow keeping things DRY. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use containers when building linux artifacts. this lets us use any version of any distro that we want for builds, without needing to "upgrade" when GitHub deprecates linux runners.
For now the runner is pinned at ubuntu-20.04 to ensure the oldest possible kernel. I left the build os at ubuntu-18.04, so that the builds are effectively unchanged from what we were getting before this PR. Of course we can now easily go back to an older distro if we want.
The release workflow also re-uses the cmake workflow instead of copying/pasting it. I'm sure we can use similar tricks to fold some of the cpack workflow, but this seems like a worthwhile improvement for now.