Don't overwrite identity json when enrolling #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smilindave26
approved these changes
Oct 20, 2022
dovholuknf
reviewed
Oct 20, 2022
| @@ -2018,6 +2025,10 @@ static void enroll_cb(ziti_config *cfg, int status, char *err, void *ctx) { | |||
| } | |||
|
|
|||
| static void enroll(int argc, char *argv[]) { | |||
| uv_loop_t *l = uv_loop_new(); | |||
There was a problem hiding this comment.
process_tunnel_commands calls enroll_ziti_async which calls this function. is it appropriate to get the log level and log init here?
There was a problem hiding this comment.
also seems like enroll should take the loop as a param?
There was a problem hiding this comment.
nevermind. it uses ziti_enroll instead. my bad! :) lgtm
dovholuknf
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #268
fixes #532
fixes #516