Ensure that BYTE_ORDER is set #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #534 |
dovholuknf
approved these changes
Oct 24, 2022
ekoby
reviewed
Oct 24, 2022
| @@ -35,6 +35,7 @@ set (LWIP_INCLUDE_DIRS | |||
| include(${LWIP_DIR}/src/Filelists.cmake) | |||
|
|
|||
| target_sources(lwipcore PRIVATE ${lwip_sys_srcs} lwip/lwiphooks_ip6.c lwip/lwiphooks_ip4.c lwip/lwip_cloned_fns.c) | |||
| target_compile_definitions(lwipcore PUBLIC CMAKE_C_BYTE_ORDER=${CMAKE_C_BYTE_ORDER}) | |||
There was a problem hiding this comment.
I would not name it CMAKE_xxx
LWIP_BYTE_ORDER would be better
There was a problem hiding this comment.
why not just set BYTE_ORDER directly here?
There was a problem hiding this comment.
Mainly because the value of the cmake variable is either BIG_ENDIAN or LITTLE_ENDIAN, so we need to make sure those macros are defined as well but cmake doesn't provide them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BYTE_ORDERC preprocessor macro is needed by lwip, but the lwip includes (and -contrib packages) don't always include the correct system includes to pick up a definition ofBYTE_ORDER. It turns out that there is no standard include file for gettingBYTE_ORDER, so this PR relies on acmakevariable, but only ifBYTE_ORDERis not already defined.