Fix file descriptor leak, clobbered route updates #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Carroll <[email protected]>
Fixes an issue where all the writes occurred at the beginning of the file. Signed-off-by: Tom Carroll <[email protected]>
If write reports an error or short count, do not execute the route update command. Signed-off-by: Tom Carroll <[email protected]>
ekoby
reviewed
May 8, 2023
| uv_fs_req_cleanup(&unlink_req); | ||
| uv_fs_req_cleanup(&tmp_req); | ||
|
|
There was a problem hiding this comment.
probably better to close the file before blowing it off the file system
There was a problem hiding this comment.
unlink just reduces the link count. The file is only removed from the filesystem when the reference count drops to zero. IMHO, the unlink-before-close is more axiomatic. If a funlink syscall is defined (FreeBSD has the funlinkat; been discussions on the Linux list at various times), you'll need the file descriptor to unlink the file.
ekoby
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR addresses a set of issues I discovered with Linux's
process_routes_updates:/tmp/ziti-tunnel-routes.XXXXXXis not closed, leading to a descriptor leak (lsofattached),uv_fs_writewas invoked withoffset=0, meaning that the prior deletes were clobbered by the write,uv_fs_writewas never checked for success, which could lead to corrupted route updates.ziti-edge-tunnel.lsof.txt