Fix file descriptor leak, clobbered route updates #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR addresses a set of issues I discovered with Linux's
process_routes_updates
:/tmp/ziti-tunnel-routes.XXXXXX
is not closed, leading to a descriptor leak (lsof
attached),uv_fs_write
was invoked withoffset=0
, meaning that the prior deletes were clobbered by the write,uv_fs_write
was never checked for success, which could lead to corrupted route updates.ziti-edge-tunnel.lsof.txt