-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/issue 548 #667
Bugfix/issue 548 #667
Conversation
# Copied from https://github.com/Debian/debhelper/blob/master/autoscripts/postinst-systemd-restartnostart | ||
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then | ||
if [ -d /run/systemd/system ]; then | ||
systemctl --system daemon-reload >/dev/null || true | ||
# TODO: Handle service restart | ||
# if [ -n "$2" ]; then | ||
# deb-systemd-invoke try-restart @SYSTEMD_UNIT_FILE_NAME@ >/dev/null || true | ||
# fi | ||
fi | ||
fi | ||
# End copied section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only real change. The rest was normalizing tabs to spaces for copied sections to avoid weird visual artifacts in spacing.
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then | ||
if [ -d /run/systemd/system ]; then | ||
systemctl --system daemon-reload >/dev/null || true | ||
# TODO: Handle service restart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the story behind this todo comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the default behavior for this shard of debhelper code, so commented out for now. Per previous discussions, service restart should be handled via some other mechanism, like debconf in the future. OpenZiti might transport config management tooling, and automatic restarts can potentially break transport during a config management operation.
No description provided.