Bugfix/issue 548 #667
Merged
Bugfix/issue 548 #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabedevops
commented
May 23, 2023
Comment on lines
+72
to
82
| # Copied from https://github.com/Debian/debhelper/blob/master/autoscripts/postinst-systemd-restartnostart | ||
| if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then | ||
| if [ -d /run/systemd/system ]; then | ||
| systemctl --system daemon-reload >/dev/null || true | ||
| # TODO: Handle service restart | ||
| # if [ -n "$2" ]; then | ||
| # deb-systemd-invoke try-restart @SYSTEMD_UNIT_FILE_NAME@ >/dev/null || true | ||
| # fi | ||
| fi | ||
| fi | ||
| # End copied section |
There was a problem hiding this comment.
This is the only real change. The rest was normalizing tabs to spaces for copied sections to avoid weird visual artifacts in spacing.
scareything
approved these changes
May 23, 2023
| if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then | ||
| if [ -d /run/systemd/system ]; then | ||
| systemctl --system daemon-reload >/dev/null || true | ||
| # TODO: Handle service restart |
There was a problem hiding this comment.
what's the story behind this todo comment?
There was a problem hiding this comment.
That's the default behavior for this shard of debhelper code, so commented out for now. Per previous discussions, service restart should be handled via some other mechanism, like debconf in the future. OpenZiti might transport config management tooling, and automatic restarts can potentially break transport during a config management operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.