update [email protected]: multi-terminator bind #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scareything
approved these changes
Jul 5, 2023
ekoby
force-pushed
the
update-ziti-sdk-v0.33.1
branch
from
6d8bc6e
to
d3ac01b
Compare
ekoby
force-pushed
the
update-ziti-sdk-v0.33.1
branch
from
87d79f7
to
f11da56
Compare
scareything
reviewed
Jul 10, 2023
CMakeLists.txt
Outdated
| @@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.20) | |||
|
|
|||
|
|
|||
| set(ZITI_SDK_DIR "" CACHE FILEPATH "developer option: use local ziti-sdk-c checkout") | |||
| set(ZITI_SDK_VERSION "0.32.8" CACHE STRING "ziti-sdk-c version or branch to use") | |||
| set(ZITI_SDK_VERSION "main" CACHE STRING "ziti-sdk-c version or branch to use") | |||
There was a problem hiding this comment.
IMO we should stick to versioned releases.
There was a problem hiding this comment.
this is to make a build for test. Not merging like this
ekoby
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings support for terminator redundancy