Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optionally send extra args to the cmake configure command #700

Merged
merged 1 commit into from
Aug 22, 2023
Merged

optionally send extra args to the cmake configure command #700

merged 1 commit into from
Aug 22, 2023

Conversation

qrkourier
Copy link
Member

No description provided.

@qrkourier qrkourier requested a review from a team as a code owner August 4, 2023 18:30
@qrkourier
Copy link
Member Author

@scareything I've improved the script for locally building this project in the ziti-builder container. I hadn't tested it after relocating to the /scripts dir, and found I needed a few additional lines to accommodate that change. I also had a need to pass extra config args like -DZITI_SDK_VERSION=main.

@qrkourier qrkourier merged commit 4d10615 into main Aug 22, 2023
10 checks passed
@qrkourier qrkourier deleted the ziti-builder-extra-args branch August 22, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scareything scareything scareything approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qrkourier @scareything