implement tunnel enroll command #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dovholuknf
reviewed
Aug 9, 2024
| @@ -626,6 +627,32 @@ static int process_cmd(const tunnel_command *cmd, command_cb cb, void *ctx) { | |||
| break; | |||
| } | |||
|
|
|||
| case TunnelCommand_Enroll: { | |||
There was a problem hiding this comment.
This needs to work with ziti-edge-tunnel.c's TunnelCommand_AddIdentity. Is that coming?
There was a problem hiding this comment.
This needs to work with
ziti-edge-tunnel.c'sTunnelCommand_AddIdentity. Is that coming?
no, this command does enrollment and returns ziti_config, AddIdentity makes assumptions on where/how config is stored (file system) which is not true for other consumers of tunneler SDK
ideally AddIdentity should be re-implemented as Enroll -> store -> LoadIdentity, but it is out of scope now
scareything
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.