Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding dockerhub support #123

Merged
merged 1 commit into from
Jan 15, 2020
Merged

adding dockerhub support #123

merged 1 commit into from
Jan 15, 2020

Conversation

juancarlostong
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 14, 2020 •
edited
Loading

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #123   +/-   ##
======================================
  Coverage    76.4%   76.4%           
======================================
  Files          23      23           
  Lines         801     801           
======================================
  Hits          612     612           
  Misses        157     157           
  Partials       32      32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a8d31...81fa48a. Read the comment docs.

mikecdavis
mikecdavis approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once this is confirmed to work as expected we should add a section to the README.md.

@juancarlostong juancarlostong merged commit ef7643f into master Jan 15, 2020
@juancarlostong juancarlostong deleted the jctong/dockerhub branch January 15, 2020 00:01
@pawels-optimizely pawels-optimizely mentioned this pull request Mar 5, 2020
Closed
@msohailhussain msohailhussain mentioned this pull request Mar 19, 2020
Closed
@juancarlostong juancarlostong mentioned this pull request Mar 23, 2020
Merged
@yasirfolio3 yasirfolio3 mentioned this pull request Mar 24, 2020
Merged
@fscelliott fscelliott mentioned this pull request Mar 30, 2020
Merged
@juancarlostong juancarlostong mentioned this pull request Apr 1, 2020
Merged
@msohailhussain msohailhussain mentioned this pull request Apr 30, 2020
Merged
@mikecdavis mikecdavis mentioned this pull request May 20, 2020
Merged
@fscelliott fscelliott mentioned this pull request Jun 12, 2020
Closed
@fscelliott fscelliott mentioned this pull request Jun 30, 2020
Closed
@oakbani oakbani mentioned this pull request Jul 14, 2020
Closed
@msohailhussain msohailhussain mentioned this pull request Jul 14, 2020
Merged
This was referenced Jul 15, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 22, 2020
Merged
Merged
@fscelliott fscelliott mentioned this pull request Jul 30, 2020
Merged
This was referenced Aug 17, 2020
Merged
Merged
Merged
@msohailhussain msohailhussain mentioned this pull request Sep 9, 2020
Merged
This was referenced Sep 21, 2020
Merged
Merged
Merged
@ooola ooola mentioned this pull request Oct 1, 2020
Closed
@fscelliott fscelliott mentioned this pull request Oct 15, 2020
Closed
@msohailhussain msohailhussain mentioned this pull request Jan 18, 2021
Closed
This was referenced Jan 18, 2021
Closed
Merged
Closed
@fscelliott fscelliott mentioned this pull request Mar 3, 2021
Merged
This was referenced Apr 15, 2021
Merged
Open
Merged
@msohailhussain msohailhussain mentioned this pull request May 12, 2021
Merged
@keppel2 keppel2 mentioned this pull request Aug 17, 2021
Closed
@msohailhussain msohailhussain mentioned this pull request Sep 3, 2021
Closed
@msohailhussain msohailhussain mentioned this pull request Apr 4, 2022
Closed
@yasirfolio3 yasirfolio3 mentioned this pull request Dec 20, 2022
Merged
@msohailhussain msohailhussain mentioned this pull request Dec 20, 2022
Merged
@mnoman09 mnoman09 mentioned this pull request Feb 28, 2023
Merged
@msohailhussain msohailhussain mentioned this pull request Feb 28, 2023
Merged
@andrewleap-optimizely andrewleap-optimizely mentioned this pull request Mar 14, 2023
Closed
@mnoman09 mnoman09 mentioned this pull request Mar 15, 2023
Closed
@pulak-opti pulak-opti mentioned this pull request Aug 2, 2024
Merged
@pulak-opti pulak-opti mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecdavis mikecdavis mikecdavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juancarlostong @mikecdavis