Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute error and task scheduling error #25

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

psolomin
Copy link

@psolomin psolomin commented May 1, 2023

This PR fixes #24 and missing attribute error in the logging call: pod.namespace.

It also makes it possible to specify full attributes' sets for volume mounts.

@psolomin psolomin changed the title Adjustments Fix attribute error and task scheduling error May 1, 2023
@psolomin
Copy link
Author

psolomin commented May 3, 2023

@dav009 @marekliszka may I get a review on this change please?

I also wonder if a new PyPi release is planned. The latest I see in PyPi is 1y ago.

Otherwise things like read_only, sub_path, etc are dropped from the final spec.
```
================================================================ short test summary info =================================================================
FAILED test/test_task.py::test_task_can_be_scheduled_by_luigi - luigi.worker.TaskException: Task of class DummyK8sTask not initialized. Did you override __init__ and forget to call super(...).__init__?
======================================================== 1 failed, 18 passed, 1 warning in 1.69s =========================================================
nox > Command pytest  failed with exit code 1

```
@psolomin
Copy link
Author

@akislou seen your recent merge to master - can you please tell if there's a chance someone still does PR review in this repo?

Thanks in advance.

@dav009
Copy link
Contributor

dav009 commented May 17, 2023

@psolomin 🙇 Thank you for your hard work in this contribution.

I will take a look at this PR in the following days 🙇

@gphillips8frw
Copy link
Contributor

@psolomin We will take a look at your PR hopefully this week.

Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task can not be scheduled
4 participants