Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement get_feature_variable and create unit tests #191

Merged
merged 12 commits into from
Jul 24, 2019
Merged

Implement get_feature_variable and create unit tests #191

merged 12 commits into from
Jul 24, 2019

Conversation

brandonhudavid
Copy link
Contributor

@brandonhudavid brandonhudavid commented Jul 22, 2019 •
edited
Loading

Summary

  • Implement get_feature_variable method to return value of variable with any type
  • Create new unit tests to ensure functionality of get_feature_variable

Python is a dynamically-typed language, like JavaScript, so it suffices to have a single method return the value of a feature variable rather than have a separate method for each possible feature variable type.

Test plan

  • Enable gherkin integration tests for Python in FSC suite and python-testapp

Issues

@coveralls
Copy link

coveralls commented Jul 23, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.0006%) to 99.712% when pulling d143400 on brandon/get_feat_var into 968a54e on master.

@brandonhudavid brandonhudavid changed the title (WIP) Implement get_feature_variable and create unit tests Implement get_feature_variable and create unit tests Jul 23, 2019
aliabbasrizvi
aliabbasrizvi reviewed Jul 24, 2019
View reviewed changes
optimizely/optimizely.py Outdated Show resolved Hide resolved
tests/test_optimizely.py Outdated Show resolved Hide resolved
mikeproeng37
mikeproeng37 approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the thorough unit test coverage. Good to go once you take up @aliabbasrizvi on his suggestion 😄

@brandonhudavid brandonhudavid merged commit e9abbac into master Jul 24, 2019
@brandonhudavid brandonhudavid deleted the brandon/get_feat_var branch July 24, 2019 22:10
@brandonhudavid brandonhudavid mentioned this pull request Aug 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi left review comments

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandonhudavid @coveralls @mikeproeng37 @aliabbasrizvi