Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install): Updating message to fix installation issues #224

Merged
merged 1 commit into from
Dec 5, 2019
Merged

fix(install): Updating message to fix installation issues #224

merged 1 commit into from
Dec 5, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

Summary

Thanks to @emielrv for reporting and figuring out the issue

Issues

Fixes #220

@aliabbasrizvi aliabbasrizvi requested a review from a team as a code owner November 28, 2019 05:09
@aliabbasrizvi aliabbasrizvi removed their assignment Nov 28, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.646% when pulling 31b9fd4 on ali/fix_encoding into d3ffe33 on master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.646% when pulling 31b9fd4 on ali/fix_encoding into d3ffe33 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.646% when pulling 31b9fd4 on ali/fix_encoding into d3ffe33 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.646% when pulling 31b9fd4 on ali/fix_encoding into d3ffe33 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.646% when pulling 31b9fd4 on ali/fix_encoding into d3ffe33 on master.

mikeproeng37
mikeproeng37 approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@aliabbasrizvi aliabbasrizvi merged commit 9fee8ff into master Dec 5, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/fix_encoding branch December 5, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pip raises UnicodeDecodeError when installing on windows
4 participants
@aliabbasrizvi @coveralls @mikeproeng37 @optimizely-codereview-bot