Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for send_flag_decisions #300

Merged
merged 13 commits into from
Oct 8, 2020
Merged

feat: support for send_flag_decisions #300

merged 13 commits into from
Oct 8, 2020

Conversation

pawels-optimizely
Copy link
Contributor

@pawels-optimizely pawels-optimizely commented Sep 25, 2020 •
edited
Loading

Summary

  • Add experiment/feature flag key, and decision type to impression events.
  • Send events for ALL decision types if send_flag_decisions is enabled.
  • Add Metadata field to EventBatch.Decisions to capture metadata.flag_key, metadata.rule_key, metadata.rule_type, metadata.variation_key

https://optimizely.atlassian.net/browse/OASIS-7106

@pawels-optimizely pawels-optimizely requested a review from a team as a code owner September 25, 2020 23:00
@coveralls
Copy link

coveralls commented Sep 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 96.34% when pulling 2b9e45d on pawel/send_flag_decisions into 2b1d68b on master.

@pawels-optimizely pawels-optimizely removed their assignment Sep 28, 2020
aliabbasrizvi
aliabbasrizvi suggested changes Sep 29, 2020
View reviewed changes
optimizely/event/payload.py Show resolved Hide resolved
optimizely/event/user_event_factory.py Outdated Show resolved Hide resolved
optimizely/optimizely.py Outdated Show resolved Hide resolved
optimizely/project_config.py Show resolved Hide resolved
@pawels-optimizely pawels-optimizely removed their assignment Sep 29, 2020
aliabbasrizvi
aliabbasrizvi suggested changes Sep 30, 2020
View reviewed changes
optimizely/event/payload.py Outdated Show resolved Hide resolved
optimizely/event/user_event_factory.py Outdated Show resolved Hide resolved
optimizely/optimizely.py Outdated Show resolved Hide resolved
@pawels-optimizely pawels-optimizely removed their assignment Oct 5, 2020
aliabbasrizvi
aliabbasrizvi suggested changes Oct 6, 2020
View reviewed changes
optimizely/event/event_factory.py Outdated Show resolved Hide resolved
optimizely/event/event_factory.py Outdated Show resolved Hide resolved
optimizely/event/user_event_factory.py Show resolved Hide resolved
optimizely/optimizely.py Outdated Show resolved Hide resolved
@pawels-optimizely pawels-optimizely removed their assignment Oct 7, 2020
aliabbasrizvi
aliabbasrizvi approved these changes Oct 8, 2020
View reviewed changes
optimizely/event/user_event_factory.py Outdated Show resolved Hide resolved
optimizely/optimizely.py Outdated Show resolved Hide resolved
optimizely/optimizely.py Outdated Show resolved Hide resolved
@pawels-optimizely pawels-optimizely merged commit 4b05245 into master Oct 8, 2020
@pawels-optimizely pawels-optimizely deleted the pawel/send_flag_decisions branch October 8, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@zashraf1985 zashraf1985 Awaiting requested review from zashraf1985

Assignees
No one assigned
Labels
🤖 4 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pawels-optimizely @coveralls @aliabbasrizvi @zashraf1985 @optimizely-codereview-bot