Process#spawn should call #to_io on non-IO file descriptor objects #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
|
I have submitted my Oracle's Contributor Agreement Application and it is being reviewed. |
jcouball
changed the title
oracle-contributor-agreement
bot
added
OCA Verified
eregon
approved these changes
Dec 19, 2022
* Avoid `should_not raise_error` * Use mock() instead of manually doing it
|
Thank you, Benoit! |
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an object is passed as the value to a
Process#spawnredirection option AND that object isn't a Symbol, Array, Integer, or an IO object AND that object responds to#to_io, thenProcess#spawnshould call#to_ioon that object to get the file descriptor.In TruffleRuby 22.3.0 and head,
Process#spawnraises an error in this situation without calling the object's#to_iomethod.The MRI implementation has done this since 2.0.0 and JRuby has done this since 9.4.0.0. I have created the project jcouball/convert_to_fd_test to illustrate this. The project contains RSpec tests that test this scenario and uses Github Actions to run these tests on different versions of MRI, JRuby, and TruffleRuby. The results of running these tests on different Rubies can be found here.
I am not able to run the spec in Windows and an hoping those are exercised via the CI build.