-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PoC for multi arch image create/update #1450
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1450 +/- ##
==========================================
- Coverage 85.46% 80.41% -5.06%
==========================================
Files 108 113 +5
Lines 3825 4094 +269
==========================================
+ Hits 3269 3292 +23
- Misses 332 576 +244
- Partials 224 226 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xiaoxuan Wang <[email protected]>
Do you have some doc write up on how this works? |
@sajayantony I have a docs/proposals/multi-arch.md write up in this PR. |
Signed-off-by: Xiaoxuan Wang <[email protected]>
|
||
- `--add`: Add a manifest to the index. The manifest will be added as the last element of the index. | ||
- `--remove`: Remove a manifest from the index. | ||
- `--annotation`: Update annotations for the index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if a user is trying to remove an annotation?
``` | ||
|
||
Flags: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to support add or remove artifact type and subject?
Would it be better to make a PR that isn't a draft with the doc so everyone can work out the details? After that merges, then a PR with the changes. |
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
This draft PR is for demonstration and discussion purposes only. There will be formal PRs to implement the features. |
@wangxiaoxuan273 I think what @TerryHowe means is to have separate a PR for the proposal. |
Resolves #1053
Private release: https://github.com/wangxiaoxuan273/oras/releases/tag/v1.2.0-multi-arch