Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dudect ready for C++ #23

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

FAlbertDev
Copy link
Contributor

  • Rename variables named class into clazz
  • Add explicit casts for calloc
  • Remove spaces at line end (not C++ relevant)

- Rename variables named class into clazz
- Add explicit casts for calloc
@oreparaz
Copy link
Owner

Thanks. I'm positive about this. Two questions:

@FAlbertDev
Copy link
Contributor Author

Shouldn't we include the extern "C" {...} logic around this (possibly guarded by __cplusplus)?

Sure! I did't know about this. (added in d9241fe)

Did you test this? how?

I used the following CMake example project, using the dudect.h header:
dudect_cpp_example.zip

Build and execute:
cmake . && make && ./dudect_example

@oreparaz
Copy link
Owner

Thanks! Merging...

@oreparaz oreparaz merged commit 05b48d8 into oreparaz:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants