Skip to content

Commit

Permalink
Restrict usages of special decomposition.
Browse files Browse the repository at this point in the history
  • Loading branch information
HechtiDerLachs committed May 8, 2024
1 parent 7134331 commit 47b9dc6
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions src/Rings/mpoly-ideals.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@ julia> L = minimal_primes(I)
function minimal_primes(I::MPolyIdeal; algorithm::Symbol = :GTZ, cache::Bool=true)
has_attribute(I, :minimal_primes) && return get_attribute(I, :minimal_primes)::Vector{typeof(I)}
R = base_ring(I)
if is_zero(dim(I))
if coefficient_ring(R) isa QQField && is_zero(dim(I))
L = Singular.LibAssprimeszerodim.assPrimes(singular_generators(I))
result = typeof(I)[ideal(R, q) for q in L]
cache && set_attribute!(I, :minimal_primes=>result)
Expand Down Expand Up @@ -1120,14 +1120,6 @@ function minimal_primes(
has_attribute(I, :minimal_primes) && return get_attribute(I, :minimal_primes)::Vector{typeof(I)}

R = base_ring(I)

if is_zero(dim(I)) # Special functionality available here
# Flattening does not do good in the examples we tested
L = Singular.LibAssprimeszerodim.assPrimes(singular_generators(I))
result = typeof(I)[ideal(R, q) for q in L]
cache && set_attribute!(I, :minimal_primes=>result)
return result
end

is_one(I) && return typeof(I)[]

Expand Down

0 comments on commit 47b9dc6

Please sign in to comment.