Test algebraic independence #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
reviewed
Sep 15, 2023
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
afkafkafk13
approved these changes
Sep 15, 2023
Comment on lines
+133
to
+138
| @testset "are_algebraically_independent" begin | ||
| R, (x, y) = polynomial_ring(QQ, ["x", "y"]) | ||
| V = [x, y] | ||
| fl, I = are_algebraically_independent(V) | ||
| @test fl | ||
| @test is_zero(I) |
There was a problem hiding this comment.
Please also do an algebraically dependent example in the test.
|
The non-examples are in the doc tests.Von meinem iPhone gesendetAm 15.09.2023 um 23:16 schrieb Anne Frühbis-Krüger ***@***.***>:
@afkafkafk13 approved this pull request.
In test/Rings/mpoly_affine_algebras.jl:
***@***.*** "are_algebraically_independent" begin
+ R, (x, y) = polynomial_ring(QQ, ["x", "y"])
+ V = [x, y]
+ fl, I = are_algebraically_independent(V)
+ @test fl
+ @test is_zero(I)
Please also do an algebraically dependent example in the test.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.