Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair flattenings of graded modules #3217

Closed
wants to merge 67 commits into from
Closed

Repair flattenings of graded modules #3217

wants to merge 67 commits into from

Commits on Jan 24, 2024

  1. Some small fix for Wolfram.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    8f128cd View commit details
    Browse the repository at this point in the history

  2. Another small fix for Wolfram.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    a9bc8b7 View commit details
    Browse the repository at this point in the history

  3. Fix the fix.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    10f6da5 View commit details
    Browse the repository at this point in the history

  4. Address oscar-system#2999 a bit.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    816e940 View commit details
    Browse the repository at this point in the history

  5. Fix tests.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b4d246b View commit details
    Browse the repository at this point in the history

  6. Fix docstring.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    bb0efe5 View commit details
    Browse the repository at this point in the history

  7. Add internal method for fast determination of the degree.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    39ea71c View commit details
    Browse the repository at this point in the history

  8. Avoid creating some matrices.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    2b71b7a View commit details
    Browse the repository at this point in the history

  9. Make the graded modules use the new internal method.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    5a8594f View commit details
    Browse the repository at this point in the history

  10. Add missing internal method.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    516f829 View commit details
    Browse the repository at this point in the history

  11. Repair docs.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    abb3dbc View commit details
    Browse the repository at this point in the history

  12. Fix tests.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    227c131 View commit details
    Browse the repository at this point in the history

  13. Use sparse matrices.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d67888b View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Fix tests.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    489ee3e View commit details
    Browse the repository at this point in the history

  2. Revert "Fix tests." 

    This reverts commit 489ee3e.
    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    47a0459 View commit details
    Browse the repository at this point in the history

  3. Revert "Revert "Fix tests."" 

    This reverts commit 47a0459.
    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7a627b0 View commit details
    Browse the repository at this point in the history

  4. Revert "Use sparse matrices." 

    This reverts commit d67888b.
    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    83bffbd View commit details
    Browse the repository at this point in the history

  5. Another fix.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d4c1bae View commit details
    Browse the repository at this point in the history

  6. Add some missing methods.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ba457b0 View commit details
    Browse the repository at this point in the history

  7. Fix degree function for SubquoModuleElems.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f2ca5c2 View commit details
    Browse the repository at this point in the history

  8. Fix degree function for SubquoModuleElems over generic rings.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    dafe342 View commit details
    Browse the repository at this point in the history

  9. Fix signature.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    616b885 View commit details
    Browse the repository at this point in the history

  10. Restrict signature.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    11bfd3e View commit details
    Browse the repository at this point in the history

  11. Repair simplify to avoid infinite loops.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ba0e12e View commit details
    Browse the repository at this point in the history

  12. Add some extra assertions.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d33020d View commit details
    Browse the repository at this point in the history

  13. Temporarily disable some failing tests.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    817558d View commit details
    Browse the repository at this point in the history

  14. WIP on debugging.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    cdeaf0e View commit details
    Browse the repository at this point in the history

  15. Preliminary closure with messages left where to pick up on the issues 

    [no ci].
    @HechtiDerLachs
    HechtiDerLachs committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    652d9b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Exact arithmetic check for Gröbner related functionality (oscar-syste… 

    …m#3232)
    @ederc @HechtiDerLachs
    ederc authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    8125862 View commit details
    Browse the repository at this point in the history

  2. change show for nat. symmetric/alternating groups (oscar-system#3235)

    @ThomasBreuer @HechtiDerLachs
    ThomasBreuer authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    34715b1 View commit details
    Browse the repository at this point in the history

  3. Fix function name in docstring (oscar-system#3233)

    @StevellM @HechtiDerLachs
    StevellM authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    74eaeca View commit details
    Browse the repository at this point in the history

  4. added text to a "TODO" FAQ (oscar-system#3236)

    @ThomasBreuer @HechtiDerLachs
    ThomasBreuer authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b91e2dd View commit details
    Browse the repository at this point in the history

  5. More functionality for Weyl groups (oscar-system#3051)

    @felix-roehrich @HechtiDerLachs
    felix-roehrich authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    48d176a View commit details
    Browse the repository at this point in the history

  6. better printing for RelativeBrauerGroupElem (oscar-system#3243)

    @fieker @HechtiDerLachs
    fieker authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    7962b03 View commit details
    Browse the repository at this point in the history

  7. CI: disable nightly for macos to reduce test time (oscar-system#3245)

    @benlorenz @HechtiDerLachs
    benlorenz authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    33339cb View commit details
    Browse the repository at this point in the history

  8. Some group theory changes for the OSCAR book (oscar-system#3242) 

    * Some group theory changes for the OSCAR book

* nicer grunwald_wang interface

* more
    @fingolfin @HechtiDerLachs
    fingolfin authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9e9127c View commit details
    Browse the repository at this point in the history

  9. Adds prune_with_map (oscar-system#3239) 

    * function for ModuleFP

* adds some docu

* adds export

* adds some tests

* fix tests

* isgraded -> is_graded

---------

Co-authored-by: Rafael Mohr <[email protected]>
    @RafaelDavidMohr @HechtiDerLachs
    2 people authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    5b93e19 View commit details
    Browse the repository at this point in the history

  10. tests: start message for ipc, explicit GC call (oscar-system#3229)

    @benlorenz @HechtiDerLachs
    benlorenz authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e3b1267 View commit details
    Browse the repository at this point in the history

  11. Serialization: disable IPC test until oscar-system#3184 is solved (os… 

    …car-system#3246)
    @benlorenz @HechtiDerLachs
    benlorenz authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a0ee41a View commit details
    Browse the repository at this point in the history

  12. Adjust casing in show(::MatroidRealizationSpace) (oscar-system#3244)

    @lgoettgens @HechtiDerLachs
    lgoettgens authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    1bf341c View commit details
    Browse the repository at this point in the history

  13. let right_cosets return a G-set (oscar-system#3223) 

    * let `right_cosets` return a G-set

- add `GSetByRightTransversal`
- change `right_cosets` to return a `GSetByRightTransversal` object
- change `show` methods for `GSetByElements` and `GroupCoset`

* address comments

* adjust `show` values
    @ThomasBreuer @HechtiDerLachs
    ThomasBreuer authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    7654e59 View commit details
    Browse the repository at this point in the history

  14. Fix 3107.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    222c488 View commit details
    Browse the repository at this point in the history

  15. Fix.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    7ab4d68 View commit details
    Browse the repository at this point in the history

  16. Add hotfix method for simplification of graded subquos.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    74884d3 View commit details
    Browse the repository at this point in the history

  17. Add tests.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    328464e View commit details
    Browse the repository at this point in the history

  18. Add forgetful functor for gradings of modules.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d885a29 View commit details
    Browse the repository at this point in the history

  19. Improve homology computation for simplified complexes.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ba01b46 View commit details
    Browse the repository at this point in the history

  20. Fix tests.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    8cdbdeb View commit details
    Browse the repository at this point in the history

  21. Avoid unnecessary creation of maps and adhere to some Oscar conventions.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ea1ff59 View commit details
    Browse the repository at this point in the history

  22. Make _alt_simplify available as method of prune_with_map.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a903ba8 View commit details
    Browse the repository at this point in the history

  23. Add tests to the other file, just in case.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    6045a34 View commit details
    Browse the repository at this point in the history

  24. Remove debugging artifact.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    781bf35 View commit details
    Browse the repository at this point in the history

  25. Adjust returned map.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b79c0e2 View commit details
    Browse the repository at this point in the history

  26. move tropical geometry up (oscar-system#3247)

    @fieker @HechtiDerLachs
    fieker authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    8a77b16 View commit details
    Browse the repository at this point in the history

  27. upgrade selected GAP packages at startup (oscar-system#3222)

    @ThomasBreuer @HechtiDerLachs
    ThomasBreuer authored and HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    526b8ce View commit details
    Browse the repository at this point in the history

  28. Restrict signature to the case where it has a chance to work.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    cf3c9a8 View commit details
    Browse the repository at this point in the history

  29. Add flattenings of SubModuleOfFreeModule.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f5e8b09 View commit details
    Browse the repository at this point in the history

  30. Add tests.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    1d63097 View commit details
    Browse the repository at this point in the history

  31. Some fix in presentations of graded modules.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    774f35a View commit details
    Browse the repository at this point in the history

  32. Polish the code to handle more derived pushforwards.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    27abe22 View commit details
    Browse the repository at this point in the history

  33. Add tests.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a2ceb50 View commit details
    Browse the repository at this point in the history

  34. Add some further functionality for flattenings.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    cb37408 View commit details
    Browse the repository at this point in the history

  35. Add strict transform for ClosedEmbeddings.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ac0a765 View commit details
    Browse the repository at this point in the history

  36. Add snake case constructor for covered_scheme [no ci].

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    c2dc0c9 View commit details
    Browse the repository at this point in the history

  37. Add some type stability.

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d4a21f6 View commit details
    Browse the repository at this point in the history

  38. Fix computation of regularity bound [no ci].

    @HechtiDerLachs
    HechtiDerLachs committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3a5c65b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Fix.

    @HechtiDerLachs
    HechtiDerLachs committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    9122c5f View commit details
    Browse the repository at this point in the history