Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental: Complex reflection groups #3342

Draft
wants to merge 57 commits into
base: master
Choose a base branch
from
Draft

Experimental: Complex reflection groups #3342

wants to merge 57 commits into from
+3,731 −0

Commits on Jul 12, 2024

  1. A first implementation of ComplexReflectionGroupType

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    16a4c72 View commit details
    Browse the repository at this point in the history

  2. Implemented some models for infinite series

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d1e17cc View commit details
    Browse the repository at this point in the history

  3. Added attributes to matrix models and added model name as symbol

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    473ae9b View commit details
    Browse the repository at this point in the history

  4. Update

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    fa58842 View commit details
    Browse the repository at this point in the history

  5. Add unitary_matrices. Fix in old code because it seems number field n… 

    …ames have been changed
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ab0335a View commit details
    Browse the repository at this point in the history

  6. Added model G4. Added further is_unitary functions

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    de90b23 View commit details
    Browse the repository at this point in the history

  7. Added symplectic_reflection_group

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    28e692b View commit details
    Browse the repository at this point in the history

  8. Fixed G4 LT model. Fix in unitary_matrices

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2bc05f6 View commit details
    Browse the repository at this point in the history

  9. Fixed field types in unitary_matrices

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    bdb9627 View commit details
    Browse the repository at this point in the history

  10. Implemented all exceptional Magma models and rank-2 from LT

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    67134d5 View commit details
    Browse the repository at this point in the history

  11. Added CHEVIE models for all exceptional groups

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0826135 View commit details
    Browse the repository at this point in the history

  12. Added type ComplexReflection and function unitary_reflection. All unt… 

    …ested so far.
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    bc1279a View commit details
    Browse the repository at this point in the history

  13. Merged orderedpkgs

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8052b12 View commit details
    Browse the repository at this point in the history

  14. * Improvements to is_unitary 

    * Implementation of type ComplexReflection
* Function is_complex_reflection_with_data
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d367ae6 View commit details
    Browse the repository at this point in the history

  15. Fix in scalar product (forgot complex conjugation)

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ffcb9c9 View commit details
    Browse the repository at this point in the history

  16. Moved Hermitian things now to new file hermitian_things.jl

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0aae913 View commit details
    Browse the repository at this point in the history

  17. * Fixed the LT models for the exceptionals by transosing the generators 

    * Some cleaup in the model code
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4bb1041 View commit details
    Browse the repository at this point in the history

  18. Improved construction of base fields of LT models 4-22

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9674672 View commit details
    Browse the repository at this point in the history

  19. * Using complex_conjugation2 now to also get the (trivial) complex co… 

    …njugation for totally real fields.

* Implemented LT model of H3 = G23
* Added function complex_reflections that lists all the reflections
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    70d84b4 View commit details
    Browse the repository at this point in the history

  20. The Cartan matrix is not correct yet and I think this comes from the 

    fact that the coroot business is not correct yet. In order to get
the correct definition, I will now start with the documentation and
then fix the code afterwards
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    a9e0da0 View commit details
    Browse the repository at this point in the history

  21. Merging oscar_references.bib (try)

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4abd38c View commit details
    Browse the repository at this point in the history

  22. Continued with the documentation. One minor fix in complex_reflection… 

    …_group: there was no return value for a product of types
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f6ae1f3 View commit details
    Browse the repository at this point in the history

  23. Many changes: 

    * Extended the ComplexReflection structure
* Fixed the coroot stuff
* Moved aux functions to separate files
* Documentation
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d1a32ed View commit details
    Browse the repository at this point in the history

  24. Updates to current OSCAR and removed my complex_conjugation2 since th… 

    …is was implemented in Hecke v0.30.2
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    a9b2bb6 View commit details
    Browse the repository at this point in the history

  25. Moved complex reflection group models to separare files.

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    37aaab1 View commit details
    Browse the repository at this point in the history

  26. Exceptionals back in test and passed

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    729b756 View commit details
    Browse the repository at this point in the history

  27. Added import of coroot from Oscar.LieAlgebras as suggested by J. Schm… 

    …itt to fix failing test
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    65ce497 View commit details
    Browse the repository at this point in the history

  28. Commented out is_shephard_group and field_of_definition for the momen… 

    …t because these functions are not finished yet
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    aefcf76 View commit details
    Browse the repository at this point in the history

  29. Also commented out the export of is_exceptional for the moment becaus… 

    …e not yet implemented
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    10d64f9 View commit details
    Browse the repository at this point in the history

  30. Shortened code in is_unitary as suggested

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2e15f43 View commit details
    Browse the repository at this point in the history

  31. Construction of complex conjugate of matrix in is_unitary now via map… 

    … function as suggested
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2d1af5e View commit details
    Browse the repository at this point in the history

  32. * Small fix (forgot the base field) in is_unitary 

    * Moved all imports/exports to the main project file and sorted alphabetically as suggested
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    646de0b View commit details
    Browse the repository at this point in the history

  33. Fixed isa(t, Int) == 1 thing

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    6b0949c View commit details
    Browse the repository at this point in the history

  34. Added newline to end of every file as suggested (why isn't this autom… 

    …atic?).
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    581121e View commit details
    Browse the repository at this point in the history

  35. Changed all indents from 4 to 2 spaces are per OSCAR editorconfig

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    cf81f39 View commit details
    Browse the repository at this point in the history

  36. Renamed num_ to number_of and added alias n_ as suggested.

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c0fbd00 View commit details
    Browse the repository at this point in the history

  37. Changed the unicode stuff as suggested

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7f62847 View commit details
    Browse the repository at this point in the history

  38. Removed braces in BCP97 reference as suggested

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    5f12634 View commit details
    Browse the repository at this point in the history

  39. Removed file entry from Bea00 reference

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d06b058 View commit details
    Browse the repository at this point in the history

  40. Removed braces in reference EG02 following suggestion

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0caf7e0 View commit details
    Browse the repository at this point in the history

  41. Used accented character in reference ST54 following suggestion and ra… 

    …n bibtool
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c4ecaac View commit details
    Browse the repository at this point in the history

  42. Added newlines to end of doc files as well

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f245d54 View commit details
    Browse the repository at this point in the history

  43. Using jldoctest now following suggestion

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    cc48d5a View commit details
    Browse the repository at this point in the history

  44. Added parent check in scalar_product following suggestion

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b041675 View commit details
    Browse the repository at this point in the history

  45. Two typos in doc

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f0d5051 View commit details
    Browse the repository at this point in the history

  46. Several minor things following suggestions

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    78117bb View commit details
    Browse the repository at this point in the history

  47. Moved a comment to where it belongs

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ba76295 View commit details
    Browse the repository at this point in the history

  48. Raising a not implemented error in is_symplectic_reflection_group ins… 

    …tead of returning false
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9ec0bdb View commit details
    Browse the repository at this point in the history

  49. Implemented function symplectic_doubling

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e15a3fb View commit details
    Browse the repository at this point in the history

  50. Removed that @ before jldoctest

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    adbfd24 View commit details
    Browse the repository at this point in the history

  51. Merging oscar_references.bib (once more)

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8fbc4ce View commit details
    Browse the repository at this point in the history

  52. Made is_complex_reflection_group into an honest test

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8c00fae View commit details
    Browse the repository at this point in the history

  53. Added a debug option in is_complex_reflection_with_data that prints t… 

    …he property that failts if input is not a complex reflection
    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7b8e0e4 View commit details
    Browse the repository at this point in the history

  54. Merging orderedpkgs

    @ulthiel
    ulthiel committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d8a1e95 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Made QQAlgField and QQAlgFieldElem const

    @ulthiel
    ulthiel committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    909acf7 View commit details
    Browse the repository at this point in the history

  2. Minor code readability improvement in is_orthogonal and is_unitary

    @ulthiel
    ulthiel committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    e26b261 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'master' into ut/complex_reflection_groups

    @lgoettgens
    lgoettgens committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    084f0b0 View commit details
    Browse the repository at this point in the history