polynomial_ring cached=false for combinatorics #3856
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Jun 13, 2024
| @@ -918,7 +918,7 @@ q^3 - 7*q^2 + 14*q - 8 | |||
| ``` | |||
| """ | |||
| function characteristic_polynomial(M::Matroid) | |||
There was a problem hiding this comment.
These functions touched here should all at some point be changed allow passing in the polynomial ring, as discussed here in our dev docs
(To be clear, that's not a request to change this PR)
fingolfin
reviewed
Jul 17, 2024
Comment on lines
+939
to
940
| R, q = polynomial_ring(ZZ, 'q'; cached=false) | ||
| p = characteristic_polynomial(M) |
There was a problem hiding this comment.
Suggested change
| R, q = polynomial_ring(ZZ, 'q'; cached=false) | |
| p = characteristic_polynomial(M) | |
| p = characteristic_polynomial(M) | |
| R = parent(p) |
| @@ -936,7 +936,7 @@ q^2 - 6*q + 8 | |||
| ``` | |||
| """ | |||
| function reduced_characteristic_polynomial(M::Matroid) | |||
| R, q = polynomial_ring(ZZ, 'q') | |||
| R, q = polynomial_ring(ZZ, 'q'; cached=false) | |||
| p = characteristic_polynomial(M) | |||
| c = Vector{Int}(undef,degree(p)) | |||
There was a problem hiding this comment.
Huh... that seems risky, couldn't one have examples where an Int would over- or underflow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests have now problems with different parent rings, see discussion at #2455.
Maybe @bschroter can help fixing the tests?