Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets poly ring caching to false for invariant theory #3864

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Sets poly ring caching to false for invariant theory #3864

merged 2 commits into from
Jun 17, 2024

Conversation

ederc
Copy link
Member

@ederc ederc commented Jun 17, 2024

See #2455.

@ederc ederc requested review from joschmitt and wdecker June 17, 2024 08:46
joschmitt
joschmitt approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! (I pushed a commit that fixes the formatting.)

@joschmitt joschmitt enabled auto-merge (squash) June 17, 2024 08:57
@codecov Codecov
Copy link

codecov bot commented Jun 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.83%. Comparing base (b1cc9b7) to head (4154318).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3864   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files         581      581           
  Lines       80009    80009           
=======================================
  Hits        65475    65475           
  Misses      14534    14534
Files Coverage Δ
src/InvariantTheory/affine_algebra.jl 98.80% <100.00%> (ø)
src/InvariantTheory/fundamental_invariants.jl 97.11% <ø> (ø)

@joschmitt joschmitt merged commit 8a1076f into oscar-system:master Jun 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschmitt joschmitt joschmitt approved these changes

@wdecker wdecker Awaiting requested review from wdecker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ederc @joschmitt