-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docu for matroid realization spaces as affine schemes #3982
Add docu for matroid realization spaces as affine schemes #3982
Conversation
Co-authored-by: Lars Göttgens <[email protected]>
Hi, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3982 +/- ##
==========================================
+ Coverage 84.30% 84.33% +0.02%
==========================================
Files 596 596
Lines 81894 81895 +1
==========================================
+ Hits 69041 69065 +24
+ Misses 12853 12830 -23
|
Yes. But that's the case since #1658. This PR does not change anything about that. It only documents these features.
Not that I know of. Feel free to try it out!
I do not quite understand. If I call In any case: Being an instance of an affine scheme should not affect any performance whatsoever. It just means that
Nothing more, nothing less. |
…em#3982) * Add section on matroid realization spaces as affine schemes. * Fix bug. * Update experimental/MatroidRealizationSpaces/docs/src/introduction.md Co-authored-by: Lars Göttgens <[email protected]> --------- Co-authored-by: Lars Göttgens <[email protected]>
As it turned out during the ICMS, these features were apparently not known to (some of?) the developers of matroid realization spaces. So I thought it might be worthwhile to add some documentation.
Still looking forward to testing and improving our smoothness tests for more complicated matroids!
ping: @bschroter , @dcorey2814 , @danteluber .