Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fglm groebner bases for some orderings #4029

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix fglm groebner bases for some orderings #4029

merged 1 commit into from
Aug 28, 2024

Conversation

joschmitt
Copy link
Member

@joschmitt joschmitt commented Aug 20, 2024 •
edited by lgoettgens
Loading

Resolves #4026

@joschmitt joschmitt requested a review from ederc August 20, 2024 08:42
@joschmitt joschmitt linked an issue Aug 20, 2024 that may be closed by this pull request
fglm crashes for some destination orderings #4026
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (6caa552) to head (841d37e).
Report is 11 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4029   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         597      597           
  Lines       82197    82197           
=======================================
  Hits        69508    69508           
  Misses      12689    12689
Files Coverage Δ
src/Rings/groebner.jl 90.04% <100.00%> (ø)

@joschmitt joschmitt added triage and removed triage labels Aug 21, 2024
@joschmitt joschmitt mentioned this pull request Aug 22, 2024
Closed
@lgoettgens lgoettgens changed the title Fix #4026 Fix flgm groebner bases for some orderings Aug 28, 2024
@lgoettgens
Copy link
Member

@jankoboehm approved this orally

@fieker fieker merged commit ee1ad22 into oscar-system:master Aug 28, 2024
28 checks passed
@joschmitt joschmitt deleted the js/fix4026 branch August 28, 2024 09:54
@joschmitt joschmitt changed the title Fix flgm groebner bases for some orderings Fix fglm groebner bases for some orderings Aug 28, 2024
@joschmitt joschmitt removed the triage label Aug 28, 2024
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 13, 2024
@joschmitt @HechtiDerLachs
Fix oscar-system#4026 (oscar-system#4029)
0671918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ederc ederc Awaiting requested review from ederc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fglm crashes for some destination orderings
3 participants
@joschmitt @lgoettgens @fieker