LieAlgebras: Add *(::WeylGroupElem, ::RootSpaceElem)
#4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: LieAlgebras
experimental
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4041 +/- ##
==========================================
+ Coverage 84.15% 84.65% +0.50%
==========================================
Files 598 598
Lines 82386 82460 +74
==========================================
+ Hits 69330 69805 +475
+ Misses 13056 12655 -401
|
lgoettgens
changed the title
*(::WeylGroupElem, ::RootSpaceElem)*(::WeylGroupElem, ::RootSpaceElem)
lgoettgens
changed the title
*(::WeylGroupElem, ::RootSpaceElem)*(::WeylGroupElem, ::RootSpaceElem)
felix-roehrich
approved these changes
Aug 23, 2024
|
This is ready for merge. |
joschmitt
approved these changes
Aug 23, 2024
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 13, 2024
…4041) * Add `*(::WeylGroupElem, ::RootSpaceElem)` * Small refactorings * Add some more tests * make rank 0 root system work * Add one more test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed yesterday.
cc @antonydellavecchia