-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lie algebras: more progress #4053
Open
lgoettgens
wants to merge
15
commits into
oscar-system:master
Choose a base branch
from
lgoettgens:lg/coxeter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: LieAlgebras
experimental
Only changes experimental parts of the code
labels
Aug 28, 2024
lgoettgens
force-pushed
the
lg/coxeter
branch
4 times, most recently
from
August 30, 2024 14:12
c9f266e
to
3640a14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4053 +/- ##
==========================================
+ Coverage 84.64% 84.76% +0.11%
==========================================
Files 612 614 +2
Lines 83250 83966 +716
==========================================
+ Hits 70469 71170 +701
- Misses 12781 12796 +15
|
lgoettgens
force-pushed
the
lg/coxeter
branch
from
September 5, 2024 14:45
3640a14
to
cd9043c
Compare
lgoettgens
force-pushed
the
lg/coxeter
branch
from
September 10, 2024 12:11
18f00d5
to
972c8ff
Compare
fingolfin
reviewed
Sep 10, 2024
fingolfin
reviewed
Sep 10, 2024
Co-authored-by: Max Horn <[email protected]>
fingolfin
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the following changes/additions:
isomorphism(FPGroup, ::WeylGroup)
via Coxeter relations. Already known information likeis_finite
andorder
gets set in the result as well to allow for better handling in GAP.dot(::WeightLatticeElem, ::WeightLatticeElem)
dominant_character
,character
, andtensor_product_decomposition
now use the root system, if available, and only fall back to GAP otherwise. (@benlorenz this should resolve the rest of cases of Make LieAlgebraModule tests better gc-able #3913 (comment))This is still a draft since I would like to wait for #4036 to get merged first to avoid conflicts.