Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache Galois results (in AbsSimpleField) #4056

Merged
merged 2 commits into from
Aug 29, 2024
Merged

cache Galois results (in AbsSimpleField) #4056

merged 2 commits into from
Aug 29, 2024

Conversation

fieker
Copy link
Contributor

@fieker fieker commented Aug 29, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (910b61b) to head (aa067d6).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/NumberTheory/GaloisGrp/GaloisGrp.jl 81.81% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4056      +/-   ##
==========================================
+ Coverage   84.16%   84.63%   +0.47%     
==========================================
  Files         599      600       +1     
  Lines       82409    82620     +211     
==========================================
+ Hits        69357    69929     +572     
+ Misses      13052    12691     -361
Files with missing lines Coverage Δ
src/NumberTheory/GaloisGrp/GaloisGrp.jl 78.58% <81.81%> (+0.81%) ⬆️

... and 49 files with indirect coverage changes

thofma
thofma approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@thofma thofma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a simple test

@thofma thofma enabled auto-merge (squash) August 29, 2024 21:22
@thofma thofma merged commit 70de637 into master Aug 29, 2024
29 checks passed
@thofma thofma deleted the cacheGalois branch August 29, 2024 22:36
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 13, 2024
@fieker @HechtiDerLachs
cache Galois results (in AbsSimpleField) (oscar-system#4056)
a8b0203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thofma thofma thofma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fieker @thofma