make sure char values are in the correct field #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: groups
experimental
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4057 +/- ##
==========================================
+ Coverage 84.16% 84.67% +0.50%
==========================================
Files 599 600 +1
Lines 82409 82610 +201
==========================================
+ Hits 69357 69946 +589
+ Misses 13052 12664 -388
|
thofma
reviewed
Aug 29, 2024
| @@ -807,7 +807,7 @@ gmodule(k::fpField, C::GModule{<:Any, <:AbstractAlgebra.FPModule{fpFieldElem}}) | |||
| continue | |||
| end | |||
| T = action(C, r) | |||
| push!(chr, (c, trace(matrix(T)))) | |||
| push!(chr, (c, K(trace(matrix(T))))) | |||
There was a problem hiding this comment.
Out of curiosity, how could that not be in K?
There was a problem hiding this comment.
Not sure.. I am scared about the default field(s), the GAP <-> Oscar FF conversion and algebraic closures...
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
could/ chould fix a Heisenbug (cannot convert Rational to MultGroupElem) and others....