Add @attr types in simple cases
#4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afkafkafk13
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Those in my courtyard are fine. ( src/AlgebraicGeometry/Schemes/CoveredSchemes/Objects/Properties.jl )
ToricVarieties is in @HereAround 's courtyard.
afkafkafk13
reviewed
Aug 29, 2024
There was a problem hiding this comment.
I'm not @jankoboehm , but from my point of view the changes around rings are spot-on.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4059 +/- ##
==========================================
- Coverage 84.66% 84.63% -0.04%
==========================================
Files 600 600
Lines 82610 82610
==========================================
- Hits 69944 69919 -25
- Misses 12666 12691 +25
|
|
For |
|
Yes, this is o.k. |
afkafkafk13
approved these changes
Aug 30, 2024
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 13, 2024
* Add `@attr` type in LieAlgebras * Add `@attr` type around lattices * Add `@attr` type around schemes * Add `@attr` type around rings * Fix some inference issue in group code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one only adds
@attrto a function without giving a type, one shadows all inference of this function for callers of this function as the@attrcode changes the inference result toAny. This PR thus adds types there, where it was obvious to me what the return type is, or where the compiler was able to prove a concrete return type (if one removes the@attrto allow for real inference).The commits are partitioned by the area they touch. Let me ping some people in the different areas here to make them aware / get a review.