Ensure that images are hidden (#711)

Signed-off-by: Christian Berendt <[email protected]>
osism · Dec 18, 2023 · 5556e43 · 5556e43
1 parent e57862a
commit 5556e43
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/openstack_image_manager/manage.py b/openstack_image_manager/manage.py
@@ -1097,7 +1097,11 @@ def manage_outdated_images(self, managed_images: set) -> list:
                             logger.info("Deactivating image '%s'" % image)
                             self.conn.image.deactivate_image(cloud_image.id)
 
-                        if self.CONF.hide and not self.CONF.dry_run:
+                        if (
+                            self.CONF.hide
+                            and not self.CONF.dry_run
+                            and cloud_image.visibility != "community"
+                        ):
                             logger.info(
                                 "Setting visibility of '%s' to 'community'" % image
                             )
@@ -1111,6 +1115,13 @@ def manage_outdated_images(self, managed_images: set) -> list:
                 logger.info(
                     f"Image '{image}' will not be deleted, {counter[image_name]} <= {last}"
                 )
+                if (
+                    self.CONF.hide
+                    and not self.CONF.dry_run
+                    and cloud_image.visibility != "community"
+                ):
+                    logger.info("Setting visibility of '%s' to 'community'" % image)
+                    self.conn.image.update_image(cloud_image.id, visibility="community")
             elif (
                 counter[image_name] < last and self.CONF.hide and not self.CONF.dry_run
             ):

diff --git a/playbooks/real-world.yml b/playbooks/real-world.yml
@@ -9,4 +9,4 @@
 
     - role: tox
       vars:
-        tox_extra_args: -- --hide --hypervisor kvm --force --keep --delete --yes-i-really-know-what-i-do
+        tox_extra_args: -- --hypervisor kvm --force --keep --latest --hide