-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to speedup dockerfile build time #2264
Conversation
This is sad :( You need to use
Two repo workarounds:
The first repo copies the entire internal dockerkit local directory via CI into github action cache, but this is overly expensive. (Your adding a minute due to its size of excess data per github issue reports. Still would net save us 1.5 minute tho) This is what the first repo does. Ideally we could just copy the relevant part of the internal buildkit cache state, unsure if theres documentation on where this all goes. (Maybe thats what the second repo does) |
Wait maybe we can just copy out the relevant buildkit cache:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What is the purpose of the change
Brief Changelog
Add go cache to dockerfile
Testing and Verifying
This change is already covered by E2E tests