fix(fossid-webapp): creatScan response can be polymorphic
#8541
+49
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some rare circumstances, `createScan` can return an error message as data payload instead of the scan id. This commit changes the function's signature to make it polymorphic. Fixes oss-review-toolkit#8462. Signed-off-by: Nicolas Nobelis <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -24,6 +24,8 @@ | |||
|
|
|||
| import io.kotest.core.spec.style.StringSpec | |||
| import io.kotest.matchers.collections.beEmpty | |||
| import io.kotest.matchers.collections.shouldContainExactly | |||
Check warning
Code scanning / detekt
Unused Imports are dead code and should be removed. Warning
|
Typo in "creatScan" -> "createScan". |
Yes but this PR is dead as a dodo. I could not make it work 😞 I think to fix the related bug, we should wait for the OpenAPI update of FossID (and maybe move the KxS then too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some rare circumstances,
createScancan return an error message as data payload instead of the scan id. This commit changes the function's signature to make it polymorphic.Fixes #8462.