Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the CII-Best-Practices requirements with the documentation #129

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Align the CII-Best-Practices requirements with the documentation #129

merged 3 commits into from
Mar 18, 2022

Conversation

jonasbb
Copy link
Contributor

@jonasbb jonasbb commented Mar 8, 2022

The remediation section states that only a passing score is required for this check to pass:

We give full credit to projects that meet the passing criteria, which is a significant achievement for many projects.

A passing score currently equals 5.
https://github.com/ossf/scorecard/blob/e128c3de82607e1b285185da9c76a5262255b180/checks/cii_best_practices.go

See #110 for more details.

The remediation section states that only a passing score is required for this check to pass:
> We give full credit to projects that meet the passing criteria, which is a significant achievement for many projects.

A passing score currently equals 5.
https://github.com/ossf/scorecard/blob/e128c3de82607e1b285185da9c76a5262255b180/checks/cii_best_practices.go

See #110 for more details.
@justaugustus justaugustus added this to In progress in Scorecard via automation Mar 10, 2022
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and very sorry for the later reply - I was OOO.

Scorecard automation moved this from In progress to Reviewer approved Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #129 (50401d0) into main (a43ad23) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files           2        2           
  Lines         127      127           
=======================================
  Hits           95       95           
  Misses         25       25           
  Partials        7        7           

@laurentsimon laurentsimon merged commit 7290c22 into ossf:main Mar 18, 2022
Scorecard automation moved this from Reviewer approved to Done Mar 18, 2022
justaugustus pushed a commit to justaugustus/scorecard that referenced this pull request May 26, 2022
…f/scorecard-action#129)

The remediation section states that only a passing score is required for this check to pass:
> We give full credit to projects that meet the passing criteria, which is a significant achievement for many projects.

A passing score currently equals 5.
https://github.com/ossf/scorecard/blob/e128c3de82607e1b285185da9c76a5262255b180/checks/cii_best_practices.go

See #110 for more details.

Co-authored-by: laurentsimon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants