🐛 Pinned-Dependencies: Fix invalid shell file handling #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehors
changed the title
|
Integration tests success for |
lehors
changed the title
|
Integration tests success for |
ristomcgehee
suggested changes
Nov 21, 2021
Parsing errors are meant to be discarded but aren't. This patch changes the code so that the error is indeed discarded and checking continues as intended and adds a unit test for it. Signed-off-by: Arnaud J Le Hors <[email protected]>
lehors
force-pushed
the
fix_faulty_shell_file_handling
branch
from
7c139ad
to
50be3da
Compare
|
Integration tests success for |
|
Integration tests success for |
ristomcgehee
approved these changes
Nov 23, 2021
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing errors are meant to be discarded but aren't. This patch
changes the code so that the error is indeed discarded and checking
continues as intended.
Signed-off-by: Arnaud J Le Hors [email protected]
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
See Issue Pinned_Dependencies check stops on faulty shell files when it is meant to continue #1307
What is the new behavior (if this is a feature change)?
The parsing error is discarded as intended and a score is given as a result.
The bottom of the description of Issue Pinned_Dependencies check stops on faulty shell files when it is meant to continue #1307 shows the new output.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No