✨ Add support for RequiresLastPushReview in Branch Protection for GitHub #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
requested review from
olivekl,
azeemshaikh38,
justaugustus,
naveensrinivasan and
spencerschrock
as code owners
laurentsimon
force-pushed
the
feat/lastapproval
branch
from
f65607c
to
3a699bb
Compare
|
friendly ping for review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2492 +/- ##
==========================================
+ Coverage 39.92% 39.97% +0.05%
==========================================
Files 122 122
Lines 9852 9863 +11
==========================================
+ Hits 3933 3943 +10
- Misses 5637 5638 +1
Partials 282 282 |
|
@spencerschrock we're hitting rate limiting on e2e with the GITHUB_TOKEN. Has this been happening recently? I added scorecard run on PR a few days ago, and I wonder if this is the root cause of the problem. |
Following up offline for more details. Likely an issue with which tokens we're using for our e2e tests and for criticality score @calebbrown fyi |
|
Anyone has cycles to review this PR? |
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
laurentsimon
force-pushed
the
feat/lastapproval
branch
3 times, most recently
from
34aaf14
to
a87712d
Compare
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
raghavkaul
reviewed
Dec 7, 2022
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
|
rate limiting hit :/ @spencerschrock did you re-create a PAT? |
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
naveensrinivasan
approved these changes
Dec 9, 2022
laurentsimon
force-pushed
the
feat/lastapproval
branch
from
0fe8e14
to
c385756
Compare
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
laurentsimon
force-pushed
the
feat/lastapproval
branch
from
4b9bdbc
to
20eeabb
Compare
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
laurentsimon
force-pushed
the
feat/lastapproval
branch
from
20eeabb
to
37941b5
Compare
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
azeemshaikh38
approved these changes
Dec 13, 2022
azeemshaikh38
had a problem deploying
to
integration-test
GitHub Actions
Failure
laurentsimon
force-pushed
the
feat/lastapproval
branch
from
3f100fe
to
28e0505
Compare
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
laurentsimon
force-pushed
the
feat/lastapproval
branch
from
675163b
to
abbf355
Compare
laurentsimon
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
…Hub (ossf#2492) * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> Signed-off-by: laurentsimon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2475
GitHub introduced a new branch protection setting called "Require approval of the most recent push". It seems to be retrievable only via an admin token.