Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Gitlab: add cron repos #3208

Merged
merged 7 commits into from
Jun 29, 2023
Merged

✨ Gitlab: add cron repos #3208

merged 7 commits into from
Jun 29, 2023

Conversation

raghavkaul
Copy link
Contributor

What kind of change does this PR introduce?

  • Reduce nightly cron repos from 5.5k -> 1k
  • Add 5.5k repos to weekly cron
  • Return sce.ErrRepoUnreachable if GitLab repo is private. For errors like the following, we now skip those repos:
"time="2023-06-23T19:36:12Z" level=info msg="error processing request: error during RunScorecard: internal error: ListCommits:error during commitsHandler.setup: request for commits failed with GET https://gitlab.com/api/v4/projects/31233563/repository/commits: 404 {message: 404 Repository Not Found}""

Score distributions from running against 250 GitLab repos in the emulator (each "x" is 10 repos):

0-0.9:
1-1.9:
2-2.9:
3-3.9:
4-4.9:xx
5-5.9:xxxxxxxxxxxx
6-6.9:xxxxxxxx
7-7.9:
8-8.9:
9-9.9:

Signed-off-by: Raghav Kaul <[email protected]>
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #3208 (5fced75) into main (c72cfd5) will decrease coverage by 5.52%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3208      +/-   ##
==========================================
- Coverage   66.23%   60.71%   -5.52%     
==========================================
  Files         168      168              
  Lines       12600    12611      +11     
==========================================
- Hits         8345     7657     -688     
- Misses       3789     4536     +747     
+ Partials      466      418      -48     

Signed-off-by: Raghav Kaul <[email protected]>
@raghavkaul raghavkaul temporarily deployed to integration-test June 29, 2023 19:24 — with GitHub Actions Inactive
@raghavkaul raghavkaul merged commit c8a7324 into ossf:main Jun 29, 2023
36 of 37 checks passed
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
* remove experimental flag

Signed-off-by: Raghav Kaul <[email protected]>

* add gitlab repos to weekly

Signed-off-by: Raghav Kaul <[email protected]>

* rename selected -> releasetest

Signed-off-by: Raghav Kaul <[email protected]>

* check repo access level for private repos

Signed-off-by: Raghav Kaul <[email protected]>

* Move e2e test to unit tests

Signed-off-by: Raghav Kaul <[email protected]>

* Require token for test

Signed-off-by: Raghav Kaul <[email protected]>

---------

Signed-off-by: Raghav Kaul <[email protected]>
Signed-off-by: Allen Shearin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants