🌱 Enforce make add-projects for GitHub and GitLab repos
#3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
this binary doesn't need the build protos Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Leaving as a draft for right this second, pending discussion from @raghavkaul about the gitlab project list |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3780 +/- ##
==========================================
- Coverage 75.45% 68.66% -6.80%
==========================================
Files 230 230
Lines 15621 15621
==========================================
- Hits 11787 10726 -1061
- Misses 3108 4258 +1150
+ Partials 726 637 -89 |
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
naveensrinivasan
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
approved these changes
Jan 16, 2024
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
CI change and corresponding documentation
What is the current behavior?
make add-projectsis optional and it doesn't apply to GitLab reposWhat is the new behavior (if this is a feature change)?**
make add-projectsis required and it does apply to GitLab reposWhich issue(s) this PR fixes
Related to #3764
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)