Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Spelling #3804

Merged
merged 89 commits into from
Jan 26, 2024
Merged

📖 Spelling #3804

merged 89 commits into from
Jan 26, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 18, 2024

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

The misspellings have been reported at
https://github.com/jsoref/scorecard/actions/runs/7565320059/attempts/1#summary-20600890152

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

The action will report that the changes in this PR would make it happy:
https://github.com/jsoref/scorecard/actions/runs/7565320271/attempts/1#summary-20600890502

Which issue(s) this PR fixes

Special notes for your reviewer

I'm happy to drop any particular changes / changes to any particular files/paths or to split this as requested.

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

  • I'm concerned that the changes to jsonBranchProtectionSettings may be breaking. I think most of the other changes are harmless...

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref requested a review from a team as a code owner January 18, 2024 04:31
@jsoref jsoref requested review from justaugustus and raghavkaul and removed request for a team January 18, 2024 04:31
Makefile Show resolved Hide resolved
README.md Show resolved Hide resolved
checks/evaluation/pinned_dependencies.go Show resolved Hide resolved
checks/fileparser/github_workflow_test.go Show resolved Hide resolved
checks/raw/binary_artifact.go Outdated Show resolved Hide resolved
checks/testdata/securitypolicy/04_textAndDisclosureVulns Outdated Show resolved Hide resolved
cmd/package_managers_test.go Show resolved Hide resolved
pkg/json_raw_results.go Outdated Show resolved Hide resolved
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Copy link
Contributor Author

jsoref commented Jan 20, 2024

Thanks @spencerschrock (this comment is mostly present so that it's easier to see the diff for the force push here in case there's another force push later).

@jsoref
Copy link
Contributor Author

jsoref commented Jan 26, 2024

So, should this be 👻 ? 🐛 ? I think we're ruled out the things we think are ⚠️ worthy...
I don't think it's ✨ and while some of the changes are 📖, many aren't.

Is it 🌱 because it's "other"?

@spencerschrock
Copy link
Contributor

So, should this be 👻 ? 🐛 ? I think we're ruled out the things we think are ⚠️ worthy... I don't think it's ✨ and while some of the changes are 📖, many aren't.

Is it 🌱 because it's "other"?

I was debating between :seedling: and :book:, so happy to accept either.
I usually merge typo fixes as :book: since they don't change any of the behavior, even if it's strictly not documentation.

@jsoref jsoref changed the title ⚠️ Spelling :boo: Spelling Jan 26, 2024
@jsoref jsoref changed the title :boo: Spelling 📖 Spelling Jan 26, 2024
@jsoref
Copy link
Contributor Author

jsoref commented Jan 26, 2024

Sold. Note that it might be worthwhile to update the documentation to that effect (to some extent, projects should try to reduce "cognitive load" on external contributors).

Thanks for the fast iteration, I appreciate it.

@spencerschrock spencerschrock enabled auto-merge (squash) January 26, 2024 23:00
@spencerschrock spencerschrock merged commit 3b94825 into ossf:main Jan 26, 2024
37 of 38 checks passed
@jsoref jsoref deleted the spelling branch January 27, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants