Switching from path param to query param

ostyn · Mar 27, 2017 · d08487d · d08487d
1 parent 5e56a2b
commit d08487d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/backend/backend.py b/backend/backend.py
@@ -39,9 +39,9 @@
 compress = Compress(app)
 access_token = "YOUR_TOKEN_HERE"
 
-@app.route('/oneDriveImageProxy/<path:url>')
-def oneDriveImageProxy(url):
-    url = unquote(url)
+@app.route('/oneDriveImageProxy', methods=['GET'])
+def oneDriveImageProxy():
+    url = unquote(request.args.get('url'))
     parsedUrl = urlparse(url)
     if not (parsedUrl.netloc.endswith('livefilestore.com')):
         return jsonify({'error':"Image source not supported."})

diff --git a/frontend/src/converters/markdown-format.js b/frontend/src/converters/markdown-format.js
@@ -11,7 +11,7 @@ export class MarkdownFormatValueConverter {
           type: 'output',
           filter: function (text, converter, options) {
             return text.replace(imgRegex, function (match, url, rest) {               
-                var addon = 'onerror="this.onerror=null;this.src=\'http://regretless.life/data/oneDriveImageProxy/\' + encodeURIComponent(this.src);" ';
+                var addon = 'onerror="this.onerror=null;this.src=\'http://regretless.life/data/oneDriveImageProxy?url=\' + encodeURIComponent(this.src);" ';
                 return match.replace("<img ", "<img " + addon);
             });
           }

diff --git a/frontend/src/widgets/post-widget.html b/frontend/src/widgets/post-widget.html
@@ -5,13 +5,13 @@
         <center>
             <a if.bind="showTitleLink" class="titleLink" route-href="route: post; params.bind: getLinkParams(post)">
                 <div class="header">
-                    <img class="headerImage" src="${post.heroPhotoUrl}" onerror="this.onerror=null;this.src='http://regretless.life/data/oneDriveImageProxy/' + encodeURIComponent(this.src);">
+                    <img class="headerImage" src="${post.heroPhotoUrl}" onerror="this.onerror=null;this.src='http://regretless.life/data/oneDriveImageProxy?url=' + encodeURIComponent(this.src);">
                     <div class="postTitle">${post.title}</div>
                 </div>
             </a>
             <div if.bind="!showTitleLink" class="titleLink">
                 <div class="header">
-                    <img class="headerImage" src="${post.heroPhotoUrl}" onerror="this.onerror=null;this.src='http://regretless.life/data/oneDriveImageProxy/' + encodeURIComponent(this.src);">
+                    <img class="headerImage" src="${post.heroPhotoUrl}" onerror="this.onerror=null;this.src='http://regretless.life/data/oneDriveImageProxy?url=' + encodeURIComponent(this.src);">
                     <div class="postTitle">${post.title}</div>
                 </div>
             </div>