Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix typo Refs: 12126 #12129

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Victor-D
Copy link
Contributor

@Victor-D Victor-D commented Jun 25, 2024

Question Answer
Branch? master
Bug fix? yes (typo in translation)
New feature? no
Breaking change? no
Tickets Fix #12126
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Fix typo in french translation files.
Translation not required.

Related

N/A

Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Victor-D, as mentioned in our contributing guidelines https://github.com/ovh/manager/blob/master/CONTRIBUTING.md#translations, only Messages_fr_FR.json can be updated.
So can you please discard the changes on packages/manager/apps/web/client/app/domain-operation/translations/Messages_fr_CA.json?

@ghyenne ghyenne changed the base branch from master to fix/MANAGER-14802 July 17, 2024 07:46
@ghyenne
Copy link
Contributor

ghyenne commented Jul 17, 2024

@Victor-D, thanks for your contribution. I created a dedicated branch for your fix.
Your commit isn't signed. You can follow this guide (https://github.com/ovh/manager/pull/12129/checks?check_run_id=26651535626) for signed your commit.

@Victor-D
Copy link
Contributor Author

Hello guys,
I've just updated and signed my commit (sorry new workstation).
Have a great day

@ghyenne ghyenne requested a review from anooparveti July 17, 2024 09:38
@ghyenne ghyenne merged commit 44bcbe1 into ovh:fix/MANAGER-14802 Jul 17, 2024
1 of 2 checks passed
@Victor-D Victor-D deleted the dev/victord/fix_12126 branch July 17, 2024 09:55
ghyenne pushed a commit that referenced this pull request Jul 18, 2024
anooparveti pushed a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faute orthographe dans le panel Opérations en cours
4 participants