Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(savings-plan): check savings plan before delete project #12874

Merged
merged 1 commit into from
Sep 2, 2024
Merged

feat(savings-plan): check savings plan before delete project #12874

merged 1 commit into from
Sep 2, 2024

Conversation

lionel95200x
Copy link
Contributor

@lionel95200x lionel95200x commented Aug 29, 2024 •
edited
Loading

Question Answer
Branch? feat/savings-plan-epic
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #TAPC-1281
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Check if user have savings plan before deleting a PCI project to display Support Message

Related

@lionel95200x lionel95200x requested a review from a team as a code owner August 29, 2024 12:19
@lionel95200x lionel95200x requested review from tibs245, qpavy and MaximeBajeux and removed request for a team August 29, 2024 12:19
@lionel95200x lionel95200x force-pushed the feat/TAPC-1281 branch 4 times, most recently from ba4103e to 8e31e6c Compare August 29, 2024 13:13
feat: check savings plan before delete pci project
239a340 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

y4nnL
y4nnL reviewed Aug 30, 2024
View reviewed changes
packages/manager/modules/pci/src/projects/project/edit/remove/remove.controller.js
@@ -15,14 +26,64 @@ export default class {
this.goBack();
}

$onInit() {
Copy link
Contributor

@y4nnL y4nnL Aug 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

canDeleteProject should be moved to the routing section of the component as it is a prerequisite

canDeleteProject: /* @ngInject */ ($http, projectId) =>
  $http
    .get(`/services?resourceName=${projectId}`)
    .then(({ data: [serviceId] }) =>
      serviceId
        ? $http
            .get(`/services/${serviceId}/savingsPlans/subscribed`)
            .then(({ data: savingsPlans }) =>
              savingsPlans.every(({ status }) => status !== 'ACTIVE'),
            )
        : true,
    ),

Don't forget to bind it

canDeleteProject: '<'

@lionel95200x lionel95200x merged commit 1fb5a03 into feat/savings-plan-epic Sep 2, 2024
13 of 14 checks passed
@lionel95200x lionel95200x deleted the feat/TAPC-1281 branch September 2, 2024 09:23
lionel95200x added a commit that referenced this pull request Sep 2, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
7a7c324 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 2, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
81463d4 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 3, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
6dd23d3 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 3, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
b259bfa 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 3, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
26e01e9 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 5, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
41a8766 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 5, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
19c7937 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 5, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
b466b2b 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 9, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
231a85d 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 9, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
1a76aed 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 9, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
7d30f26 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 9, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
bbba7d4 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 9, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
b980ea8 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 9, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
fd9c8e7 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 9, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
a89dd11 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 9, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
62f7fe1 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 9, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
69b4f03 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 11, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
9f87aef 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 11, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
5969124 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x added a commit that referenced this pull request Sep 11, 2024
@lionel95200x
feat: check savings plan before delete pci project (#12874)
962f08f 
ref: feat/TAPC-1281

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipp972 chipp972 chipp972 approved these changes

@y4nnL y4nnL y4nnL approved these changes

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionel95200x @y4nnL @chipp972