Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai): update guides CLI section name #9588

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix(ai): update guides CLI section name #9588

merged 1 commit into from
Aug 11, 2023

Conversation

Benzhaomin
Copy link
Contributor

@Benzhaomin Benzhaomin commented Jul 7, 2023

Question Answer
Branch? develop
Issue #9677
Bug fix? yes
New feature? no
Breaking change? no
License BSD 3-Clause

Description

The guides API returns updated section names since moving docs to ServiceNow. This change fixes the list of tutorials that shows on the CLI tab of the AI dashboard.

It's all read-only and a very safe change.

JacquesLarique
JacquesLarique previously approved these changes Jul 10, 2023
qpavy
qpavy previously approved these changes Jul 10, 2023
@Benzhaomin
Copy link
Contributor Author

two other commits were pushed to this branch instead of another by mistake, now they are reverted so there's no change vs what was reviewed yesterday

Copy link
Contributor

@darsene darsene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Benzhaomin ,

You have to follow the contribution guide https://github.com/ovh/manager/blob/master/CONTRIBUTING.md (your commits aren't sign off and ticket reference is missing)

ref: Github issue #9677

Signed-off-by: Benjamin Maisonnas <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JacquesLarique JacquesLarique changed the base branch from master to release/components-w33 August 11, 2023 11:41
@JacquesLarique JacquesLarique merged commit 2a18fff into ovh:release/components-w33 Aug 11, 2023
9 of 11 checks passed
@JacquesLarique JacquesLarique mentioned this pull request Aug 11, 2023
12 tasks
JacquesLarique pushed a commit that referenced this pull request Aug 16, 2023
ref: MANAGER-11938

Signed-off-by: Benjamin Maisonnas <[email protected]>
JacquesLarique pushed a commit that referenced this pull request Aug 17, 2023
ref: MANAGER-11938

Signed-off-by: Benjamin Maisonnas <[email protected]>
BrunoMarquesOVH pushed a commit that referenced this pull request Aug 31, 2023
ref: MANAGER-11938

Signed-off-by: Benjamin Maisonnas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants