Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ai): fix private registry creation #9606

Closed
wants to merge 2 commits into from
Closed

fix(ai): fix private registry creation #9606

wants to merge 2 commits into from

Conversation

Benzhaomin
Copy link
Contributor

@Benzhaomin Benzhaomin commented Jul 11, 2023 •
edited
Loading

Question Answer
Branch? develop
Issues #9674 #9675
Bug fix? yes
New feature? no
Breaking change? no
License BSD 3-Clause

Description

Two small fixes to the AI private registry creation form:

  • the password field max length (50) was too low for some customers, also raised the username field, we have no limit on the API for both of these fields
  • the username field was called "Identifiant" and then translated to "ID" while it's a username, all translations must be updated to reflect that

@Benzhaomin Benzhaomin requested a review from a team as a code owner July 11, 2023 09:27
darsene
darsene requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@darsene darsene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Benzhaomin ,

You have to follow the contribution guide https://github.com/ovh/manager/blob/master/CONTRIBUTING.md (your commits aren't sign off and ticket reference is missing)

@Benzhaomin Benzhaomin changed the base branch from develop to master July 21, 2023 13:21
Benjamin Maisonnas added 2 commits July 21, 2023 15:34
fix: raise max length of PCI > AI Training > Private registry usernam…
9d62c41 
…e and password from 50 to 300

ref: Github issue #9675

Signed-off-by: Benjamin Maisonnas <[email protected]>
fix: fix translation of the PCI > AI Training > Private registry user…
f791bf5 
…name field

ref: Github issue #9674

Signed-off-by: Benjamin Maisonnas <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Benzhaomin
Copy link
Contributor Author

abullet33 is merging this work somewhere else, closing.

@Benzhaomin Benzhaomin closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jperchoc jperchoc jperchoc approved these changes

@darsene darsene darsene approved these changes

@abullet33 abullet33 abullet33 approved these changes

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
translation required universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Benzhaomin @jperchoc @darsene @abullet33