Revise examples #672
Merged
Revise examples #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanrhymes
approved these changes
Jul 2, 2024
mseri
reviewed
Jul 2, 2024
| @@ -1 +0,0 @@ | |||
| The examples in this folder are made based on the OCaml's toplevel and Owl's Zoo system. Please refer to [Tutorial 9: Scripting and Zoo System](https://github.com/ryanrhymes/owl/wiki/Tutorial:-Scripting-and-Zoo-System). | |||
There was a problem hiding this comment.
Could you keep the file, adding a couple of lines on how to run the examples? There is no dune file in the folder, so a priori is not obvious for a new user what to do now.
There was a problem hiding this comment.
Thanks! There is actually a dune file added to this folder, and I've updated the readme file accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep examples up-to-date with current version of Owl/OCaml, and also update all existing datasets used in examples.