Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Opening Private Link in Branded Build #1031

Closed
hosy opened this issue Sep 10, 2021 · 1 comment · Fixed by #1032
Closed

[BUG] Opening Private Link in Branded Build #1031

hosy opened this issue Sep 10, 2021 · 1 comment · Fixed by #1032
Assignees
@hosy
Labels
Type:bug Something isn't working
Milestone
11.7.1

Comments

@hosy
Copy link
Collaborator

hosy commented Sep 10, 2021

If you found a bug:

If the iOS app is branded (e.g. ownCloud.online) a private link cannot be opened in detail view.

Steps to reproduce

  1. Build a branded client (e.g. ownCloud.online)
  2. Open a file with owncloud://demo.owncloud/f/39 (please add the demo server as account before and be sure the file id exists)
  3. App will be opened, but not the account and detail view

Expected behavior

File will be opened in detail view

Actual behavior

App will be opened but does not change the view

Client

ownCloud app version:
11.7.0
@hosy hosy added the Type:bug Something isn't working label Sep 10, 2021
@hosy hosy added this to the 11.7.1-Fix milestone Sep 10, 2021
@hosy hosy self-assigned this Sep 10, 2021
hosy added a commit that referenced this issue Sep 10, 2021
@hosy
#1031 private link could not be opened in branded login view
e485916
@hosy hosy mentioned this issue Sep 10, 2021
Merged
10 tasks
@hosy hosy linked a pull request Sep 10, 2021 that will close this issue
[fix/open-private-link-branding] Open Private Link in Branded Client #1032
Merged
10 tasks
hosy added a commit that referenced this issue Sep 16, 2021
@hosy
[fix/open-private-link-branding] Open Private Link in Branded Client (#…
79b96ca 
…1032)

* #1031 private link could not be opened in branded login view

* Added Calens changelog entry

* Calens changelog updated

* Fixed a deadlock, when trying to retrieve an item for a link

Co-authored-by: hosy <[email protected]>
@jesmrec
Copy link
Contributor

jesmrec commented Sep 17, 2021

Done. Ready to 11.7.1

@jesmrec jesmrec closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hosy hosy

Labels
Type:bug Something isn't working
Projects
None yet
Milestone
11.7.1
Development

Successfully merging a pull request may close this issue.

[fix/open-private-link-branding] Open Private Link in Branded Client owncloud/ios-app
2 participants
@hosy @jesmrec