Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TUS -H 'Upload-Metadata: mtime missing #1227

Closed
michaelstingl opened this issue Jun 20, 2023 · 1 comment
Closed

[BUG] TUS -H 'Upload-Metadata: mtime missing #1227

michaelstingl opened this issue Jun 20, 2023 · 1 comment
Assignees
Milestone

Comments

@michaelstingl
Copy link
Contributor

Reported here:

Steps to reproduce

Expected behavior

Tell us what should happen

Actual behavior

Tell us what happens instead

Client

iOS version:

ownCloud app version:

Device model:

Server configuration

Web server:

Database:

PHP version:

ownCloud version:

Storage backend (external storage):

Logs

Web server error log

Insert your webserver log here

ownCloud log (data/owncloud.log)

Insert your ownCloud log here

Tell us what could be improved:

@michaelstingl
Copy link
Contributor Author

Fixed with 4b9b483

hosy added a commit that referenced this issue Sep 5, 2023
* - CreateDocumentAction: make availability dependant on OCAppProvider.supportsCreateDocument
- AccountConnection: create Open with actions dependant on OCAppProvider.supportsCreateDocument
- OpenInWebAppAction:
	- introduce new "auto" mode that uses the best available method - or shows an error
	- limit size of icons to a maximum of 32x32 points
- update SDK for new feature detection capabilities

* - add support for TUS upload mtime metadata header (fixing #1227)

* - FileProviderExtension: add additional debug output for enumerator

* FileProvider:
- add missing errorHandler calls to FileProviderContentEnumerator
- add last resort enumeration completion call to FileProviderEnumeratorObserver.dealloc
- add additional debug logging

* - FIleProviderContentEnumerator: add/refine more debug logging

* - bump version to 12.0.3 and build number to 271

* removed the logo label from the sidebar navigation bar to have more space for the logo image

* - update SDK to fix owncloud/enterprise#5811

* - fix #1254

* Example JSON + README (#1255)

Co-authored-by: Michael Stingl <[email protected]>

* Cleanup of Theming folder (#1260)

* Remove old PLIST examples

* move ownCloud.online theme + assets

* move EMM assets

* Adjust Fastfile for moved themes + assets

* updated to Xcode 14.3

* move all app resources to the correct place in one copy command

* updated to 14.3.1

---------

Co-authored-by: Michael Stingl <[email protected]>
Co-authored-by: Matthias Hühne <[email protected]>

* - FileProvider: fix enumerator queue completion slowdown/blocking

* - show vendor label in the sidebar if app is unbranded
- added accessibility label to the logo image

* - FileProvider cleanup and additional debug logging

* - BottomButtonBar: avoid collapse of selectButton (fixes owncloud/enterprise#5889)

* - add background image to welcome screen
- add support for RGBA hex values to CSS

* - change welcome screen background default color from dark to bright

* - BookmarkViewController: add .bookmarkEditor CSS selector

* - ThemeCSS: add support for $cssSelector.cssProperty

* Assets.xcassets/AppIcon.appiconset generated with fastlane + welcome screen background (#1264)

* - add background image to welcome screen
- add support for RGBA hex values to CSS

* Assets.xcassets/AppIcon.appiconset generated with fastlane

* align icon name with branding

---------

Co-authored-by: Felix Schwarz <[email protected]>
Co-authored-by: Michael Stingl <[email protected]>

* - change welcome screen background default color from dark to bright

* Assets.xcassets/AppIcon.appiconset generated with fastlane

* rename vanilla appiconset again for fastlane changes

* - ThemeCSS+SystemColors: add convenience methods to easily add CSS records for colors, incl. a set of system colors
- ThemeCollection: add system colors (f.ex. UIColor.systemBlue as `os.color.blue`) and theme base colors (as `theme.color.light` and `theme.color.dark`) to CSS object

* Vanilla: change welcome screen background default color from bright to dark

* - BookmarkViewController:
	- add permanent logo branding to top of the view
	- make branding elements use same CSS selectors as welcome screen
- ComposedMessageView: make CSS selectors extension public
- RoundCornerBackgroundView: add new .fillImage property that allows filling the view with an image with "scaleAspectFill" contentMode

* - BookmarkViewController: remove table view background image from branded builds

* - RoundCornerBackgroundView: fix bug in sizeThatFills()

* - DisplayViewController: handle nil OCQueryChangeSet.queryResult (should fix crash reported in #1245 (comment))

* fixed missing translation strings or localized function

* fixed bug in sidebar: label color got the same color as background color and label was not readable, if lightBrandColor was similar to #000000

* - FileProviderExtension: add safeguards around `[NSError fileProviderErrorForNonExistentItemWithIdentifier:]` for the case that iOS (illegally) passes in a nil `identifier`, leading to a crash in said NSError method

* [fix/overlapping-sharing-buttons] Overlapping Sharing Buttons (#1248)

* [fix/passcode-device-enforced] MDM Parameter - Enforce Passcode Setup (#1249)

* [fix/sidebar-logo] Sidebar Logo (#1247)

* [translation-sync] Translation sync (#1250)

* - minimal change to reopen PR

* [tx] updated from transifex

* [tx] updated from transifex

* [tx] updated from transifex

* [tx] updated from transifex

* - revert minimum change to THIRD_PARTY.txt

* [tx] updated from transifex

* - fixed UTF issues
- fixed missing german translations

---------

Co-authored-by: Felix Schwarz <[email protected]>
Co-authored-by: ownClouders <[email protected]>

* - update SDK

* - update SDK to update error message for OCErrorAuthorizationNoMethodData

* - add "An error occurred" to Localizable.strings

* - SDK update with updated strings

* GH workflows:
- add LocalizationTests with automatic UTF-16 to UTF-8 conversion

* - GitHub workflows: move new GH workflow out of workflows folder to avoid permission issue
- fix non-empty Branding.plist

* Translation sync (#1269)

* - minimal change to reopen PR

* [tx] updated from transifex

* [tx] updated from transifex

* [tx] updated from transifex

* [tx] updated from transifex

* - revert minimum change to THIRD_PARTY.txt

* [tx] updated from transifex

* - fixed UTF issues
- fixed missing german translations

* [tx] updated from transifex

* [tx] updated from transifex

* [tx] updated from transifex

* [tx] updated from transifex

* [tx] updated from transifex

* [tx] updated from transifex

* - fix file encoding for en-GB.lproj/Localizable.strings

---------

Co-authored-by: Matthias Hühne <[email protected]>
Co-authored-by: ownClouders <[email protected]>

* - update ios-sdk to gain ocstringstool
- remove LocalizationTests.swift
- remove UTF-8/16 enforcements for .strings files from ownCloud.xcodeproj
- add tools/normalizestrings based on ios-sdk/ocstringstool
- update GH action (now normalize-strings.yml)
- normalize strings files to UTF-8

* - update release notes for 12.0.3

* - NSObject+ThemeApplication: fix wrong label colors for ThemeCSSLabels that are also subject to NSObject.applyThemeCollection() calls

* - AppRootViewController + InitialSetupViewController: move initial setup view into own view controller
- InitialSetupViewController: implement status bar style support for consistent status bar colors also pre-iOS 17

* - fix iOS 17 initial setup color issue

* - address owncloud/core#40953 (comment) via SDK update

* - fix: rename of a bookmark is not always reflected in the account list

* - BottomButtonBar: adapt layout dynamically to size class, placing the promptText above the buttons in any but regular horizontal class size and stretching the buttons to fill the space beneath it

* - ClientSidebarViewController: properly initialize accountsControllerSectionSource with item version tracking

* - fix SwiftLint warnings

* added missing Calens changelog files

* added latest app store release notes

* Calens changelog updated

---------

Co-authored-by: Matthias Hühne <[email protected]>
Co-authored-by: Michael Stingl <[email protected]>
Co-authored-by: Michael Stingl <[email protected]>
Co-authored-by: Matthias Hühne <[email protected]>
Co-authored-by: ownClouders <[email protected]>
Co-authored-by: hosy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants