Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Keyboard Shortcuts in PDF Detail View #902

Closed
hosy opened this issue Feb 20, 2021 · 0 comments · Fixed by #908
Closed

[BUG] Keyboard Shortcuts in PDF Detail View #902

hosy opened this issue Feb 20, 2021 · 0 comments · Fixed by #908
Milestone
11.6.0

Comments

@hosy
Copy link
Collaborator

hosy commented Feb 20, 2021

If you found a bug:

Keyboard Shortcuts in the PDF detail view are missing:

  • Search
  • Jump to Page
  • Show page overview
  • More Actions

Steps to reproduce

  1. Connect a hardware keyboard
  2. Open PDF in detail view
  3. Long press Command button to show the available command list

Expected behavior

All mentioned features should be available via keyboard shortcuts.

Actual behavior

Mentioned features are not reachable via keyboard.

Client

iOS version:
14.4

ownCloud app version:
11.5.2

Device model:
iPad
hosy added a commit that referenced this issue Feb 22, 2021
@hosy
#902 #903
25ca2fa 
- added missing keyboard shortcuts in PDF detail view
- added keyboard shortcuts for media playback
- added missing more action keyboard shortcuts in detail view
- fixed broken keyboard shortcuts arrow navigation in UITableView between sections
@hosy hosy mentioned this issue Feb 23, 2021
Merged
17 tasks
@hosy hosy linked a pull request Feb 23, 2021 that will close this issue
[fix/keyboards-shortcuts] Added missing keyboard shortcuts / fix broken keyboard navigation #908
Merged
17 tasks
@hosy hosy added this to the 11.6.0-Current milestone Mar 17, 2021
@hosy hosy closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.6.0
1 participant
@hosy