Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Japanese(2-Byte character) input support #916

Closed
9 tasks
Bables55 opened this issue Mar 4, 2021 · 2 comments · Fixed by #929
Closed
9 tasks

[FEATURE REQUEST] Japanese(2-Byte character) input support #916

Bables55 opened this issue Mar 4, 2021 · 2 comments · Fixed by #929
Assignees
@hosy
Labels
p2-high Escalation, on top of current planning, release blocker Type:bug Something isn't working
Milestone
11.6.0

Comments

@Bables55
Copy link

Bables55 commented Mar 4, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
When users take a picture with the "Scan Document" function and enter the file name, there is a problem with entering Japanese (2-byte characters).
I've written about it in my forum, including the current issues, so please take a look there as well.
https://central.owncloud.org/t/support-for-2-byte-characters-in-scan-document/29856

Describe the solution you'd like
I want to use Japanese (2-byte characters) in file names without any problems.

Describe alternatives you've considered
The only way to solve this problem is to use 1-byte characters.

Additional context
1: https://od.lk/s/M18yNDA3ODk3NDdf/oc-flickjapanese.MP4 2
2: https://od.lk/s/M18yNDA3ODg4ODNf/oc-qwertyjapanese.mp4

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)
@Bables55 Bables55 changed the title [FEATURE REQUEST] Japanese(2-Byte charactor) input support [FEATURE REQUEST] Japanese(2-Byte character) input support Mar 4, 2021
@hosy hosy added the Type:bug Something isn't working label Mar 4, 2021
@hosy hosy added this to the 11.6.0-Current milestone Mar 4, 2021
@jesmrec jesmrec added the p2-high Escalation, on top of current planning, release blocker label Mar 8, 2021
hosy added a commit that referenced this issue Mar 12, 2021
@hosy
#916 UITextfield: fixed a problem that text cursor jumps to the end o…
c0322a6 
…f the text after entering a Japanese character
@hosy hosy mentioned this issue Mar 12, 2021
Merged
10 tasks
@hosy hosy linked a pull request Mar 12, 2021 that will close this issue
[fix/japanese-input-support] Japanese Input Support #929
Merged
10 tasks
@hosy
Copy link
Collaborator

hosy commented Mar 12, 2021

@Bables55 thank you for reporting this bug.
The problem is fixed now and will be available with next version 11.6.

hosy added a commit that referenced this issue Mar 17, 2021
@hosy @felix-schwarz
[fix/japanese-input-support] Japanese Input Support (#929)
cc5476b 
* #916 UITextfield: fixed a problem that text cursor jumps to the end of the text after entering a Japanese character

* Calens changelog updated

* StaticTableViewRow: avoid self-triggered/circular update of textfields (user entry in textfield -> set value property -> replace value in textfield)

* Calens changelog updated

Co-authored-by: hosy <[email protected]>
Co-authored-by: Felix Schwarz <[email protected]>
@jesmrec
Copy link
Contributor

jesmrec commented Mar 24, 2021

Done

@jesmrec jesmrec closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hosy hosy

Labels
p2-high Escalation, on top of current planning, release blocker Type:bug Something isn't working
Projects
None yet
Milestone
11.6.0
Development

Successfully merging a pull request may close this issue.

[fix/japanese-input-support] Japanese Input Support owncloud/ios-app
3 participants
@hosy @jesmrec @Bables55