Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Detail Text View not themed in dark mode #919

Closed
hosy opened this issue Mar 4, 2021 · 1 comment · Fixed by #932
Closed

[BUG] Detail Text View not themed in dark mode #919

hosy opened this issue Mar 4, 2021 · 1 comment · Fixed by #932
Milestone
11.6.0

Comments

@hosy
Copy link
Collaborator

hosy commented Mar 4, 2021

The text detail view is now themed if dark mode theme was selected.
Text files are shown inside a web view. Not sure if it was possible to set the colors. Maybe possible by injecting CSS or JavaScript.

Steps to reproduce

  1. Open a text file in detail view

Expected behavior

  • Background color should be dark
  • Text color should be white

Check #900

Actual behavior

  • white (bright) background

Client

iOS version:
14.4

ownCloud app version:
11.5.2

Simulator Screen Shot - iPad Pro (11-inch) (2nd generation) - 2021-03-04 at 15 54 49
@hosy hosy added this to the 11.6.0-Current milestone Mar 4, 2021
hosy added a commit that referenced this issue Mar 17, 2021
@hosy
#919 fixed setting the user interface style for the QLPreviewController
c164a60 
- added themeable protocol
- setting style in protocol and after init view
- moved themeable protocol of superclass from extension in class to override it in subclass
- added changelog issue
@hosy hosy mentioned this issue Mar 17, 2021
Merged
11 tasks
@hosy hosy linked a pull request Mar 17, 2021 that will close this issue
[fix/qlpreview-dark-mode] Dark Mode Support for QLPreviewController #932
Merged
11 tasks
hosy added a commit that referenced this issue Mar 30, 2021
@hosy
[fix/qlpreview-dark-mode] Dark Mode Support for QLPreviewController (#…
86acd52 
…932)

* #919 fixed setting the user interface style for the QLPreviewController
- added themeable protocol
- setting style in protocol and after init view
- moved themeable protocol of superclass from extension in class to override it in subclass
- added changelog issue

* Calens changelog updated

* Calens changelog updated

* fixed autolayout orientation change problem on iOS 13

Co-authored-by: hosy <[email protected]>
@jesmrec
Copy link
Contributor

jesmrec commented Mar 30, 2021

Done!! Ready to 11.6

@jesmrec jesmrec closed this as completed Mar 30, 2021
@jesmrec jesmrec mentioned this issue May 5, 2021
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.6.0
Development

Successfully merging a pull request may close this issue.

[fix/qlpreview-dark-mode] Dark Mode Support for QLPreviewController owncloud/ios-app
2 participants
@hosy @jesmrec