Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Passcode section not refreshed #923

Closed
jesmrec opened this issue Mar 10, 2021 · 1 comment · Fixed by #926
Closed

[BUG] Passcode section not refreshed #923

jesmrec opened this issue Mar 10, 2021 · 1 comment · Fixed by #926
Assignees
@hosy
Labels
feature:settings Type:bug Something isn't working
Milestone
11.6.0

Comments

@jesmrec
Copy link
Contributor

jesmrec commented Mar 10, 2021

Steps to reproduce

  1. Open Settings section
  2. Enable passcode and type it correctly

Actual behavior

Yo have to go out from Settings and enter again to make the Lock and Biometrical cells visible:

Video-2021-03-10-14-37-42_1420.MP4

Expected behavior

After typing the passcode, Lock and Biometrical are visible with no further actions.

NOTE: Same behaviour when disabling passcode

iPhoneXR v14.4
milestone/11.6 -> 7896623
@jesmrec jesmrec added Type:bug Something isn't working feature:settings labels Mar 10, 2021
@hosy hosy self-assigned this Mar 11, 2021
@hosy hosy added this to the 11.6.0-Current milestone Mar 11, 2021
hosy added a commit that referenced this issue Mar 11, 2021
@hosy
#923 fixed missing completion handler, which causes the UI was not up…
e894cd8 
…dated
@hosy hosy mentioned this issue Mar 11, 2021
Merged
12 tasks
@hosy hosy linked a pull request Mar 11, 2021 that will close this issue
[fix/passcode-settings-ui-update] Passcode Settings UI Update #926
Merged
12 tasks
@jesmrec
Copy link
Contributor Author

jesmrec commented Mar 17, 2021

Problem fixed and ready to 11.6

@jesmrec jesmrec closed this as completed Mar 17, 2021
hosy added a commit that referenced this issue Mar 17, 2021
@hosy
[fix/passcode-settings-ui-update] Passcode Settings UI Update (#926)
bd7c0de 
* #923 fixed missing completion handler, which causes the UI was not updated

* added changelog issue

* Calens changelog updated

* fixed setting UI states on main thread

* Calens changelog updated

* reset the biometrical security setting, when disabling the passcode lock

Co-authored-by: hosy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hosy hosy

Labels
feature:settings Type:bug Something isn't working
Projects
None yet
Milestone
11.6.0
Development

Successfully merging a pull request may close this issue.

[fix/passcode-settings-ui-update] Passcode Settings UI Update owncloud/ios-app
2 participants
@hosy @jesmrec